From: Martin KaFai Lau <martin.lau@linux.dev>
To: Xu Kuohai <xukuohai@huaweicloud.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Yonghong Song <yonghong.song@linux.dev>,
Kui-Feng Lee <thinker.li@gmail.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 0/3] Add kernel symbol for struct_ops trampoline
Date: Tue, 12 Nov 2024 16:59:02 -0800 [thread overview]
Message-ID: <677fac6c-e66d-4fba-a89a-982888209523@linux.dev> (raw)
In-Reply-To: <20241112145849.3436772-1-xukuohai@huaweicloud.com>
On 11/12/24 6:58 AM, Xu Kuohai wrote:
> Add kernel symbol for struct_ops trampoline.
>
> Without kernel symbol for struct_ops trampoline, the unwinder may
> produce unexpected stacktraces. For example, the x86 ORC and FP
> unwinder stops stacktrace on a struct_ops trampoline address since
> there is no kernel symbol for the address.
Reviewed-by: Martin KaFai Lau <martin.lau@kernel.org>
next prev parent reply other threads:[~2024-11-13 0:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 14:58 [PATCH bpf-next v4 0/3] Add kernel symbol for struct_ops trampoline Xu Kuohai
2024-11-12 14:58 ` [PATCH bpf-next v4 1/3] bpf: Remove unused member rcu from bpf_struct_ops_map Xu Kuohai
2024-11-12 14:58 ` [PATCH bpf-next v4 2/3] bpf: Use function pointers count as struct_ops links count Xu Kuohai
2024-11-12 14:58 ` [PATCH bpf-next v4 3/3] bpf: Add kernel symbol for struct_ops trampoline Xu Kuohai
2024-11-13 0:59 ` Martin KaFai Lau [this message]
2024-11-13 1:20 ` [PATCH bpf-next v4 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=677fac6c-e66d-4fba-a89a-982888209523@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=thinker.li@gmail.com \
--cc=xukuohai@huaweicloud.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox