From: Leon Hwang <leon.hwang@linux.dev>
To: Yonghong Song <yonghong.song@linux.dev>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix bpf_iter/task_vma test
Date: Wed, 10 Jun 2026 14:00:25 +0800 [thread overview]
Message-ID: <74d31362-b1cc-4143-b112-ac0975dcb789@linux.dev> (raw)
In-Reply-To: <20260610051831.1346659-1-yonghong.song@linux.dev>
On 10/6/26 13:18, Yonghong Song wrote:
> For selftest bpf_iter/task_vma, I got a failure like below on my qemu run:
>
> test_task_vma_common:FAIL:compare_output unexpected compare_output:
> actual
> '561593546000-561593585000r--p0000000000:241256579534/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'
> != expected
> '561593546000-561593585000r--p0000000000:245551546830/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'
>
> Further debuging found out file->f_inode->i_ino value may exceed 32bit,
NIT: ^ debugging
> e.g., i_ino = 0x14c2eae35, but the format string is '%u'. This caused
> inode mismatch between bpf iter and proc result.
>
> Fix the issue by using format string '%llu' to accommodate 64bit i_ino.
>
> Fixes: e8168840e16c ("selftests/bpf: Add test for bpf_iter_task_vma")
> Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
Acked-by: Leon Hwang <leon.hwang@linux.dev>
> ---
next prev parent reply other threads:[~2026-06-10 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 5:18 [PATCH bpf-next] selftests/bpf: Fix bpf_iter/task_vma test Yonghong Song
2026-06-10 6:00 ` Leon Hwang [this message]
2026-06-10 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74d31362-b1cc-4143-b112-ac0975dcb789@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox