[PATCH bpf-next] selftests/bpf: Fix bpf_iter/task_vma test

[PATCH bpf-next] selftests/bpf: Fix bpf_iter/task_vma test

[Yonghong Song]

For selftest bpf_iter/task_vma, I got a failure like below on my qemu run:

test_task_vma_common:FAIL:compare_output unexpected compare_output:
    actual
    '561593546000-561593585000r--p0000000000:241256579534/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'
    != expected
    '561593546000-561593585000r--p0000000000:245551546830/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'

Further debuging found out file->f_inode->i_ino value may exceed 32bit,
e.g., i_ino = 0x14c2eae35, but the format string is '%u'. This caused
inode mismatch between bpf iter and proc result.

Fix the issue by using format string '%llu' to accommodate 64bit i_ino.

Fixes: e8168840e16c ("selftests/bpf: Add test for bpf_iter_task_vma")
Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
---
 tools/testing/selftests/bpf/progs/bpf_iter_task_vmas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_task_vmas.c b/tools/testing/selftests/bpf/progs/bpf_iter_task_vmas.c
index d64ba7ddaed5..d7fb561ed4fb 100644
--- a/tools/testing/selftests/bpf/progs/bpf_iter_task_vmas.c
+++ b/tools/testing/selftests/bpf/progs/bpf_iter_task_vmas.c
@@ -52,7 +52,7 @@ SEC("iter/task_vma") int proc_maps(struct bpf_iter__task_vma *ctx)
 		bpf_d_path(&file->f_path, d_path_buf, D_PATH_BUF_SIZE);
 
 		BPF_SEQ_PRINTF(seq, "%08llx ", vma->vm_pgoff << 12);
-		BPF_SEQ_PRINTF(seq, "%02x:%02x %u", MAJOR(dev), MINOR(dev),
+		BPF_SEQ_PRINTF(seq, "%02x:%02x %llu", MAJOR(dev), MINOR(dev),
 			       file->f_inode->i_ino);
 		BPF_SEQ_PRINTF(seq, "\t%s\n", d_path_buf);
 	} else {
-- 
2.52.0

Re: [PATCH bpf-next] selftests/bpf: Fix bpf_iter/task_vma test

[Leon Hwang]

On 10/6/26 13:18, Yonghong Song wrote:
> For selftest bpf_iter/task_vma, I got a failure like below on my qemu run:
> 
> test_task_vma_common:FAIL:compare_output unexpected compare_output:
>     actual
>     '561593546000-561593585000r--p0000000000:241256579534/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'
>     != expected
>     '561593546000-561593585000r--p0000000000:245551546830/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'
> 
> Further debuging found out file->f_inode->i_ino value may exceed 32bit,

NIT:      ^ debugging

> e.g., i_ino = 0x14c2eae35, but the format string is '%u'. This caused
> inode mismatch between bpf iter and proc result.
> 
> Fix the issue by using format string '%llu' to accommodate 64bit i_ino.
> 
> Fixes: e8168840e16c ("selftests/bpf: Add test for bpf_iter_task_vma")
> Signed-off-by: Yonghong Song <yonghong.song@linux.dev>

Acked-by: Leon Hwang <leon.hwang@linux.dev>

> ---

Re: [PATCH bpf-next] selftests/bpf: Fix bpf_iter/task_vma test

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Tue,  9 Jun 2026 22:18:31 -0700 you wrote:
> For selftest bpf_iter/task_vma, I got a failure like below on my qemu run:
> 
> test_task_vma_common:FAIL:compare_output unexpected compare_output:
>     actual
>     '561593546000-561593585000r--p0000000000:241256579534/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'
>     != expected
>     '561593546000-561593585000r--p0000000000:245551546830/root/devshare/bpf-next/tools/testing/selftests/bpf/test_progs'
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: Fix bpf_iter/task_vma test
    https://git.kernel.org/bpf/bpf-next/c/2e8ad1ff712d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html