From: Jiri Slaby <jirislaby@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org
Cc: patches@lists.linux.dev,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Florent Revest <revest@chromium.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
Alan Maguire <alan.maguire@oracle.com>,
Heiko Carstens <hca@linux.ibm.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.13 102/207] fprobe: Rewrite fprobe on function-graph tracer
Date: Tue, 11 Mar 2025 10:56:26 +0100 [thread overview]
Message-ID: <76c5a00f-ae15-43b8-a917-093ca63cc396@kernel.org> (raw)
In-Reply-To: <8ea06b5e-ec85-42e5-a2e9-9ad747fef217@kernel.org>
On 11. 03. 25, 10:49, Jiri Slaby wrote:
> On 11. 03. 25, 10:46, Jiri Slaby wrote:
>> On 10. 03. 25, 18:04, Greg Kroah-Hartman wrote:
>>> 6.13-stable review patch. If anyone has any objections, please let
>>> me know.
>>>
>>> ------------------
>>>
>>> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>>>
>>> [ Upstream commit 4346ba1604093305a287e08eb465a9c15ba05b80 ]
>> ...
>>> --- a/kernel/trace/Kconfig
>>> +++ b/kernel/trace/Kconfig
>>> @@ -302,11 +302,9 @@ config DYNAMIC_FTRACE_WITH_ARGS
>>> config FPROBE
>>> bool "Kernel Function Probe (fprobe)"
>>> - depends on FUNCTION_TRACER
>>> - depends on DYNAMIC_FTRACE_WITH_REGS || DYNAMIC_FTRACE_WITH_ARGS
>>> - depends on HAVE_FTRACE_REGS_HAVING_PT_REGS || !
>>> HAVE_DYNAMIC_FTRACE_WITH_ARGS
>>> - depends on HAVE_RETHOOK
>>> - select RETHOOK
>>> + depends on HAVE_FUNCTION_GRAPH_FREGS && HAVE_FTRACE_GRAPH_FUNC
>>
>> HAVE_FTRACE_GRAPH_FUNC does not exist on 6.13, so FPROBE is
>> effectively disabled by this backport.
>>
>> Is this missing (and only this?):
>> commit a762e9267dca843ced943ec24f20e110ba7c8431
>> Author: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>> Date: Thu Dec 26 14:13:34 2024 +0900
>>
>> ftrace: Add CONFIG_HAVE_FTRACE_GRAPH_FUNC
>
> With this applied, x86_64 is fixed. But ppc and s390 still loose it.
HAVE_FTRACE_GRAPH_FUNC is missing in ppc completely in upstream too (a
bug?).
s390 has it only through (here omitted):
commit 7495e179b478801433cec3cc4a82d2dcea35bf06
Author: Sven Schnelle <svens@linux.ibm.com>
Date: Thu Dec 26 14:13:48 2024 +0900
s390/tracing: Enable HAVE_FTRACE_GRAPH_FUNC
> On the top of that, arm64 can indeed have FPROBEs now (the aim of the
> patches).
>
>> thanks,
--
js
suse labs
next prev parent reply other threads:[~2025-03-11 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250310170447.729440535@linuxfoundation.org>
2025-03-10 17:04 ` [PATCH 6.13 097/207] fgraph: Replace fgraph_ret_regs with ftrace_regs Greg Kroah-Hartman
2025-03-10 17:04 ` [PATCH 6.13 098/207] fprobe: Use ftrace_regs in fprobe entry handler Greg Kroah-Hartman
2025-03-10 17:04 ` [PATCH 6.13 099/207] fprobe: Use ftrace_regs in fprobe exit handler Greg Kroah-Hartman
2025-03-10 17:04 ` [PATCH 6.13 100/207] tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs Greg Kroah-Hartman
2025-03-10 17:04 ` [PATCH 6.13 101/207] tracing: Add ftrace_fill_perf_regs() for perf event Greg Kroah-Hartman
2025-03-10 17:04 ` [PATCH 6.13 102/207] fprobe: Rewrite fprobe on function-graph tracer Greg Kroah-Hartman
2025-03-11 9:46 ` Jiri Slaby
2025-03-11 9:49 ` Jiri Slaby
2025-03-11 9:56 ` Jiri Slaby [this message]
2025-03-11 14:12 ` Greg Kroah-Hartman
2025-03-11 23:52 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76c5a00f-ae15-43b8-a917-093ca63cc396@kernel.org \
--to=jirislaby@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=kernel@xen0n.name \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=patches@lists.linux.dev \
--cc=paul.walmsley@sifive.com \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox