From: Martin KaFai Lau <martin.lau@linux.dev>
To: Kui-Feng Lee <thinker.li@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev,
Martin KaFai Lau <martin.lau@kernel.org>,
kernel test robot <lkp@intel.com>, bpf <bpf@vger.kernel.org>
Subject: Re: [linux-next:master 1465/2825] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used
Date: Thu, 1 Feb 2024 12:36:51 -0800 [thread overview]
Message-ID: <79df5a1a-3d7d-4a6a-8ebb-aaf4d9e89aaf@linux.dev> (raw)
In-Reply-To: <202401300557.z5vzn8FM-lkp@intel.com>
On 1/29/24 1:36 PM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 596764183be8ebb13352b281a442a1f1151c9b06
> commit: 0253e0590e2dc46996534371d56b5297099aed4e [1465/2825] selftests/bpf: test case for register_bpf_struct_ops().
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/202401300557.z5vzn8FM-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401300557.z5vzn8FM-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c: In function 'bpf_dummy_reg':
>>> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used [-Wunused-but-set-variable]
> 557 | int r;
> | ^
>
>
> vim +/r +557 tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
>
> 553
> 554 static int bpf_dummy_reg(void *kdata)
> 555 {
> 556 struct bpf_testmod_ops *ops = kdata;
> > 557 int r;
Kui-Feng, Please take a look. May be change the ".test_2" return type to "void"
since it is not used.
> 558
> 559 r = ops->test_2(4, 3);
> 560
> 561 return 0;
> 562 }
> 563
>
next parent reply other threads:[~2024-02-01 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202401300557.z5vzn8FM-lkp@intel.com>
2024-02-01 20:36 ` Martin KaFai Lau [this message]
2024-02-05 19:25 ` [linux-next:master 1465/2825] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79df5a1a-3d7d-4a6a-8ebb-aaf4d9e89aaf@linux.dev \
--to=martin.lau@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.lau@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox