From: Kui-Feng Lee <sinquersw@gmail.com>
To: Martin KaFai Lau <martin.lau@linux.dev>,
Kui-Feng Lee <thinker.li@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev,
Martin KaFai Lau <martin.lau@kernel.org>,
kernel test robot <lkp@intel.com>, bpf <bpf@vger.kernel.org>
Subject: Re: [linux-next:master 1465/2825] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used
Date: Mon, 5 Feb 2024 11:25:59 -0800 [thread overview]
Message-ID: <3230d5b6-dca3-4b41-bf04-479127628713@gmail.com> (raw)
In-Reply-To: <79df5a1a-3d7d-4a6a-8ebb-aaf4d9e89aaf@linux.dev>
On 2/1/24 12:36, Martin KaFai Lau wrote:
>> vim +/r +557 tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
>>
>> 553
>> 554 static int bpf_dummy_reg(void *kdata)
>> 555 {
>> 556 struct bpf_testmod_ops *ops = kdata;
>> > 557 int r;
>
> Kui-Feng, Please take a look. May be change the ".test_2" return type to
> "void" since it is not used.
>
>> 558
>> 559 r = ops->test_2(4, 3);
>> 560
>> 561 return 0;
>> 562 }
>> 563
>>
>
The fix has been landed. FYI!
https://lore.kernel.org/all/20240204061204.1864529-1-thinker.li@gmail.com/
prev parent reply other threads:[~2024-02-05 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202401300557.z5vzn8FM-lkp@intel.com>
2024-02-01 20:36 ` [linux-next:master 1465/2825] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used Martin KaFai Lau
2024-02-05 19:25 ` Kui-Feng Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3230d5b6-dca3-4b41-bf04-479127628713@gmail.com \
--to=sinquersw@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox