Re: [linux-next:master 1465/2825] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used

Re: [linux-next:master 1465/2825] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used

[Martin KaFai Lau]

On 1/29/24 1:36 PM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   596764183be8ebb13352b281a442a1f1151c9b06
> commit: 0253e0590e2dc46996534371d56b5297099aed4e [1465/2825] selftests/bpf: test case for register_bpf_struct_ops().
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/202401300557.z5vzn8FM-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401300557.z5vzn8FM-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>     tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c: In function 'bpf_dummy_reg':
>>> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used [-Wunused-but-set-variable]
>       557 |         int r;
>           |             ^
> 
> 
> vim +/r +557 tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
> 
>     553	
>     554	static int bpf_dummy_reg(void *kdata)
>     555	{
>     556		struct bpf_testmod_ops *ops = kdata;
>   > 557		int r;

Kui-Feng, Please take a look. May be change the ".test_2" return type to "void" 
since it is not used.

>     558	
>     559		r = ops->test_2(4, 3);
>     560	
>     561		return 0;
>     562	}
>     563	
> 

Re: [linux-next:master 1465/2825] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:557:13: warning: variable 'r' set but not used

[Kui-Feng Lee]

On 2/1/24 12:36, Martin KaFai Lau wrote:
>> vim +/r +557 tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
>>
>>     553
>>     554    static int bpf_dummy_reg(void *kdata)
>>     555    {
>>     556        struct bpf_testmod_ops *ops = kdata;
>>   > 557        int r;
> 
> Kui-Feng, Please take a look. May be change the ".test_2" return type to 
> "void" since it is not used.
> 
>>     558
>>     559        r = ops->test_2(4, 3);
>>     560
>>     561        return 0;
>>     562    }
>>     563
>>
> 

The fix has been landed.  FYI!
https://lore.kernel.org/all/20240204061204.1864529-1-thinker.li@gmail.com/