Re: [PATCH bpf-next v4 7/7] selftests/bpf: Add rcu_read_lock test to s390x deny list

[Yonghong Song <yhs@meta.com>]

On 11/10/22 11:37 AM, Manu Bretelle wrote:
> On Thu, Nov 10, 2022 at 10:02:01AM -0800, Yonghong Song wrote:
>> The new rcu_read_lock test will fail on s390x with the following error message:
>>
>>    ...
>>    test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
>>    test_local_storage:PASS:skel_open 0 nsec
>>    libbpf: prog 'cgrp_succ': failed to find kernel BTF type ID of '__s390x_sys_getpgid': -3
>>    libbpf: prog 'cgrp_succ': failed to prepare load attributes: -3
>>    libbpf: prog 'cgrp_succ': failed to load: -3
>>    libbpf: failed to load object 'rcu_read_lock'
>>    libbpf: failed to load BPF skeleton 'rcu_read_lock': -3
>>    test_local_storage:FAIL:skel_load unexpected error: -3 (errno 3)
>>    ...
>>
>> So add it to the s390x deny list.
>>
>> Signed-off-by: Yonghong Song <yhs@fb.com>
>> ---
>>   tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
>> index be4e3d47ea3e..dd5db40b5a09 100644
>> --- a/tools/testing/selftests/bpf/DENYLIST.s390x
>> +++ b/tools/testing/selftests/bpf/DENYLIST.s390x
>> @@ -41,6 +41,7 @@ module_attach                            # skel_attach skeleton attach failed: -
>>   mptcp
>>   netcnt                                   # failed to load BPF skeleton 'netcnt_prog': -7                               (?)
>>   probe_user                               # check_kprobe_res wrong kprobe res from probe read                           (?)
>> +rcu_read_lock                            # failed to find kernel BTF type ID of '__x64_sys_getpgid': -3                (?)
> 
> This also seems to fail on aarch64:
> ```
> 2022-11-10T18:39:39.2406543Z test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
> 2022-11-10T18:39:39.2409781Z test_local_storage:PASS:skel_open 0 nsec
> 2022-11-10T18:39:39.2413002Z test_local_storage:PASS:skel_load 0 nsec
> 2022-11-10T18:39:39.2418758Z libbpf: prog 'cgrp_succ': failed to attach: ERROR: strerror_r(-524)=22
> 2022-11-10T18:39:39.2422765Z libbpf: prog 'cgrp_succ': failed to auto-attach: -524
> 2022-11-10T18:39:39.2428250Z test_local_storage:FAIL:skel_attach unexpected error: -524 (errno 524)
> 2022-11-10T18:39:39.2431555Z #145/1   rcu_read_lock/local_storage:FAIL
> 2022-11-10T18:39:39.2435392Z #145/2   rcu_read_lock/runtime_diff_rcu_tag:OK
> 2022-11-10T18:39:39.2439296Z #145/3   rcu_read_lock/negative_tests_region:OK
> 2022-11-10T18:39:39.2443876Z #145/4   rcu_read_lock/negative_tests_rcuptr_misuse:SKIP
> 2022-11-10T18:39:39.2446212Z #145     rcu_read_lock:FAIL
> ```
> 
> Can you add the test to DENYLIST.aarch64 also?

Thanks. Will add to the next revision.

> 
> 
>>   recursion                                # skel_attach unexpected error: -524                                          (trampoline)
>>   ringbuf                                  # skel_load skeleton load failed                                              (?)
>>   select_reuseport                         # intermittently fails on new s390x setup
>> -- 
>> 2.30.2
>>