From: Manu Bretelle <chantr4@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next v4 7/7] selftests/bpf: Add rcu_read_lock test to s390x deny list
Date: Thu, 10 Nov 2022 11:37:15 -0800 [thread overview]
Message-ID: <Y21S6+9rfmwA8R8S@surya> (raw)
In-Reply-To: <20221110180201.917531-1-yhs@fb.com>
On Thu, Nov 10, 2022 at 10:02:01AM -0800, Yonghong Song wrote:
> The new rcu_read_lock test will fail on s390x with the following error message:
>
> ...
> test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
> test_local_storage:PASS:skel_open 0 nsec
> libbpf: prog 'cgrp_succ': failed to find kernel BTF type ID of '__s390x_sys_getpgid': -3
> libbpf: prog 'cgrp_succ': failed to prepare load attributes: -3
> libbpf: prog 'cgrp_succ': failed to load: -3
> libbpf: failed to load object 'rcu_read_lock'
> libbpf: failed to load BPF skeleton 'rcu_read_lock': -3
> test_local_storage:FAIL:skel_load unexpected error: -3 (errno 3)
> ...
>
> So add it to the s390x deny list.
>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
> tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
> index be4e3d47ea3e..dd5db40b5a09 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.s390x
> +++ b/tools/testing/selftests/bpf/DENYLIST.s390x
> @@ -41,6 +41,7 @@ module_attach # skel_attach skeleton attach failed: -
> mptcp
> netcnt # failed to load BPF skeleton 'netcnt_prog': -7 (?)
> probe_user # check_kprobe_res wrong kprobe res from probe read (?)
> +rcu_read_lock # failed to find kernel BTF type ID of '__x64_sys_getpgid': -3 (?)
This also seems to fail on aarch64:
```
2022-11-10T18:39:39.2406543Z test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
2022-11-10T18:39:39.2409781Z test_local_storage:PASS:skel_open 0 nsec
2022-11-10T18:39:39.2413002Z test_local_storage:PASS:skel_load 0 nsec
2022-11-10T18:39:39.2418758Z libbpf: prog 'cgrp_succ': failed to attach: ERROR: strerror_r(-524)=22
2022-11-10T18:39:39.2422765Z libbpf: prog 'cgrp_succ': failed to auto-attach: -524
2022-11-10T18:39:39.2428250Z test_local_storage:FAIL:skel_attach unexpected error: -524 (errno 524)
2022-11-10T18:39:39.2431555Z #145/1 rcu_read_lock/local_storage:FAIL
2022-11-10T18:39:39.2435392Z #145/2 rcu_read_lock/runtime_diff_rcu_tag:OK
2022-11-10T18:39:39.2439296Z #145/3 rcu_read_lock/negative_tests_region:OK
2022-11-10T18:39:39.2443876Z #145/4 rcu_read_lock/negative_tests_rcuptr_misuse:SKIP
2022-11-10T18:39:39.2446212Z #145 rcu_read_lock:FAIL
```
Can you add the test to DENYLIST.aarch64 also?
> recursion # skel_attach unexpected error: -524 (trampoline)
> ringbuf # skel_load skeleton load failed (?)
> select_reuseport # intermittently fails on new s390x setup
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-11-10 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 18:01 [PATCH bpf-next v4 0/7] bpf: Add bpf_rcu_read_lock() support Yonghong Song
2022-11-10 18:01 ` [PATCH bpf-next v4 1/7] compiler_types: Define __rcu as __attribute__((btf_type_tag("rcu"))) Yonghong Song
2022-11-10 18:01 ` [PATCH bpf-next v4 2/7] bpf: Abstract out functions to check sleepable helpers Yonghong Song
2022-11-10 18:01 ` [PATCH bpf-next v4 3/7] bpf: Add kfunc bpf_rcu_read_lock/unlock() Yonghong Song
2022-11-10 18:01 ` [PATCH bpf-next v4 4/7] bpf: Add bpf_rcu_read_lock() verifier support Yonghong Song
2022-11-10 18:01 ` [PATCH bpf-next v4 5/7] bpf: Enable sleeptable support for cgrp local storage Yonghong Song
2022-11-10 18:01 ` [PATCH bpf-next v4 6/7] selftests/bpf: Add tests for bpf_rcu_read_lock() Yonghong Song
2022-11-10 18:02 ` [PATCH bpf-next v4 7/7] selftests/bpf: Add rcu_read_lock test to s390x deny list Yonghong Song
2022-11-10 19:37 ` Manu Bretelle [this message]
2022-11-10 20:06 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y21S6+9rfmwA8R8S@surya \
--to=chantr4@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox