From: Quentin Monnet <qmo@kernel.org>
To: "Alexis Lothoré (eBPF Foundation)" <alexis.lothore@bootlin.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"Shuah Khan" <shuah@kernel.org>
Cc: ebpf@linuxfoundation.org,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: drop test_bpftool.sh
Date: Fri, 27 Feb 2026 09:31:41 +0000 [thread overview]
Message-ID: <8610334b-aa82-4fef-a9cf-41c0bfca4dbe@kernel.org> (raw)
In-Reply-To: <20260227-bpftool_feature-v1-1-a25860fd52fb@bootlin.com>
2026-02-27 09:08 UTC+0100 ~ "Alexis Lothoré (eBPF Foundation)"
<alexis.lothore@bootlin.com>
> The test_bpftool.sh script runs a python unittest script checking
> bpftool json output on different commands. As part of the ongoing effort
> to get rid of any standalone test, this script should either be
> converted to test_progs or removed.
>
> As validating bpftool json output does not bring much value to the test
> base (and because it would need test_progs to bring in a json parser),
> remove the standalone test script.
>
> Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>
Acked-by: Quentin Monnet <qmo@kernel.org>
Regarding the discussion on JSON: If you need to check bpftool's output
in other tests, it's probably OK to simply look at the plain output.
We've been discouraging people to parse the plain output because it's
not considered stable, but given that the tests and bpftool itself are
in the same repo we could always adjust any test that would break if we
changed something in the output.
Thanks for your work on this!
Quentin
next prev parent reply other threads:[~2026-02-27 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 8:08 [PATCH bpf-next] selftests/bpf: drop test_bpftool.sh Alexis Lothoré (eBPF Foundation)
2026-02-27 9:31 ` Quentin Monnet [this message]
2026-02-27 10:14 ` Alexis Lothoré
2026-03-03 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8610334b-aa82-4fef-a9cf-41c0bfca4dbe@kernel.org \
--to=qmo@kernel.org \
--cc=alexis.lothore@bootlin.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bastien.curutchet@bootlin.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ebpf@linuxfoundation.org \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox