Re: [PATCH bpf-next] selftests/bpf: drop test_bpftool.sh

["Alexis Lothoré" <alexis.lothore@bootlin.com>]

Hello Quentin,

On Fri Feb 27, 2026 at 10:31 AM CET, Quentin Monnet wrote:
> 2026-02-27 09:08 UTC+0100 ~ "Alexis Lothoré (eBPF Foundation)"
> <alexis.lothore@bootlin.com>
>> The test_bpftool.sh script runs a python unittest script checking
>> bpftool json output on different commands. As part of the ongoing effort
>> to get rid of any standalone test, this script should either be
>> converted to test_progs or removed.
>> 
>> As validating bpftool json output does not bring much value to the test
>> base (and because it would need test_progs to bring in a json parser),
>> remove the standalone test script.
>> 
>> Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>
>
>
> Acked-by: Quentin Monnet <qmo@kernel.org>
>
> Regarding the discussion on JSON: If you need to check bpftool's output
> in other tests, it's probably OK to simply look at the plain output.
> We've been discouraging people to parse the plain output because it's
> not considered stable, but given that the tests and bpftool itself are
> in the same repo we could always adjust any test that would break if we
> changed something in the output.

ACK, thanks for your input, I'll keep that in mind for the next tests to
convert (I still have some test_bpftool_synctypes that I did not check
yet).

Alexis
>
> Thanks for your work on this!
> Quentin




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com