Re: [PATCH net-next 3/5] selftests/bpf: remove sockmap + ktls tests

[Jakub Sitnicki <jakub@cloudflare.com>]

On Sat, Jun 13, 2026 at 06:40 PM -07, Jakub Kicinski wrote:
> The combination of sockmap and TLS is no longer supported - installing
> the TLS ULP on a sockmap socket (and vice versa) is now rejected. Remove
> the tests that exercise the combination along with their BPF program;
> the file covered nothing but sockmap sockets holding kTLS contexts.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  .../selftests/bpf/prog_tests/sockmap_ktls.c   | 355 ------------------
>  .../selftests/bpf/progs/test_sockmap_ktls.c   |  61 ---
>  tools/testing/selftests/bpf/test_sockmap.c    | 227 +----------
>  3 files changed, 1 insertion(+), 642 deletions(-)
>  delete mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_ktls.c
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> index 6ed8e149e3d5..cda6b22cf759 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c

[...]

>  static void run_ktls_test(int family, int sotype)
>  {
>  	if (test__start_subtest("tls simple offload"))
>  		test_sockmap_ktls_offload(family, sotype);

Nit: We probably don't need to keep this one test around.
It tests pure kTLS and overlaps with selftests/net/tls.c.

> -	if (test__start_subtest("tls tx cork"))
> -		test_sockmap_ktls_tx_cork(family, sotype, false);
> -	if (test__start_subtest("tls tx cork with push"))
> -		test_sockmap_ktls_tx_cork(family, sotype, true);
> -	if (test__start_subtest("tls tx egress with no buf"))
> -		test_sockmap_ktls_tx_no_buf(family, sotype, true);
> -	if (test__start_subtest("tls tx with pop"))
> -		test_sockmap_ktls_tx_pop(family, sotype);
> -	if (test__start_subtest("tls verdict with tls rx"))
> -		test_sockmap_ktls_verdict_with_tls_rx(family, sotype);
>  }

Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>