Re: [PULL] Networking for v6.3

Re: [PULL] Networking for v6.3

[Linus Torvalds]

On Tue, Feb 21, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.3

Ok, so this is a bit nitpicky, but commit c7ef8221ca7d ("ice: use GNSS
subsystem instead of TTY") ends up doing odd things to kernel configs.

My local configuration suddenly grew this:

    CONFIG_ICE_GNSS=y

which is pretty much nonsensical.

The reason? It's defined as

    config ICE_GNSS
            def_bool GNSS = y || GNSS = ICE

and so it gets set even when both GNSS and ICE are both disabled,
because 'n' = 'n'.

Does it end up *mattering*? No. It's only used in the ICE driver, but
it really looks all kinds of odd, and it makes the resulting .config
files illogical.

Maybe I'm the only one who looks at those things. I do it because I
think they are sometimes easier to just edit directly, but also
because for me it's a quick way to see if somebody has sneaked in new
config options that are on by default when they shouldn't be.

I'd really prefer to not have the resulting config files polluted with
nonsensical config options.

I suspect it would be as simple as adding a

        depends on ICE != n

to that thing, but I didn't get around to testing that. I thought it
would be better to notify the guilty parties.

Anyway, this has obviously not held up me pulling the networking
changes, and you should just see this as (yet another) sign of "yeah,
Linus cares about those config files to a somewhat unhealthy degree".

                      Linus

Re: [PULL] Networking for v6.3

[Jakub Kicinski]

On Tue, 21 Feb 2023 18:46:26 -0800 Linus Torvalds wrote:
> On Tue, Feb 21, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.3  
> 
> Ok, so this is a bit nitpicky, but commit c7ef8221ca7d ("ice: use GNSS
> subsystem instead of TTY") ends up doing odd things to kernel configs.
> 
> My local configuration suddenly grew this:
> 
>     CONFIG_ICE_GNSS=y
> 
> which is pretty much nonsensical.
> 
> The reason? It's defined as
> 
>     config ICE_GNSS
>             def_bool GNSS = y || GNSS = ICE
> 
> and so it gets set even when both GNSS and ICE are both disabled,
> because 'n' = 'n'.
> 
> Does it end up *mattering*? No. It's only used in the ICE driver, but
> it really looks all kinds of odd, and it makes the resulting .config
> files illogical.
> 
> Maybe I'm the only one who looks at those things. I do it because I
> think they are sometimes easier to just edit directly, but also
> because for me it's a quick way to see if somebody has sneaked in new
> config options that are on by default when they shouldn't be.

Oh, we only check oldconfig so the hidden options don't pop up.
Let me make a note...

> I'd really prefer to not have the resulting config files polluted with
> nonsensical config options.
> 
> I suspect it would be as simple as adding a
> 
>         depends on ICE != n
> 
> to that thing, but I didn't get around to testing that. I thought it
> would be better to notify the guilty parties.
> 
> Anyway, this has obviously not held up me pulling the networking
> changes, and you should just see this as (yet another) sign of "yeah,
> Linus cares about those config files to a somewhat unhealthy degree".

Thanks! We'll take care of it shortly.

Re: [PULL] Networking for v6.3

[Alexander Lobakin]

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 21 Feb 2023 18:46:26 -0800

> On Tue, Feb 21, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.3
> 
> Ok, so this is a bit nitpicky, but commit c7ef8221ca7d ("ice: use GNSS
> subsystem instead of TTY") ends up doing odd things to kernel configs.
> 
> My local configuration suddenly grew this:
> 
>     CONFIG_ICE_GNSS=y
> 
> which is pretty much nonsensical.
> 
> The reason? It's defined as
> 
>     config ICE_GNSS
>             def_bool GNSS = y || GNSS = ICE
> 
> and so it gets set even when both GNSS and ICE are both disabled,
> because 'n' = 'n'.

It was me who originally suggested this and I forgot ice doesn't have
its own Kconfig file and doesn't guard its options under `if ICE`, sorry
=\ It would work if it had.

> 
> Does it end up *mattering*? No. It's only used in the ICE driver, but
> it really looks all kinds of odd, and it makes the resulting .config
> files illogical.
> 
> Maybe I'm the only one who looks at those things. I do it because I

FWIW I do as well, ironically enough :D
But I have `CONFIG_ICE=m` on all of my systems, so there was no chance
for me to notice this. Thanks!

> think they are sometimes easier to just edit directly, but also
> because for me it's a quick way to see if somebody has sneaked in new
> config options that are on by default when they shouldn't be.
> 
> I'd really prefer to not have the resulting config files polluted with
> nonsensical config options.
> 
> I suspect it would be as simple as adding a
> 
>         depends on ICE != n
> 
> to that thing, but I didn't get around to testing that. I thought it
> would be better to notify the guilty parties.

Patch is on its way already, it just drops the opt and uses CONFIG_GNSS
directly.

> 
> Anyway, this has obviously not held up me pulling the networking
> changes, and you should just see this as (yet another) sign of "yeah,
> Linus cares about those config files to a somewhat unhealthy degree".
> 
>                       Linus
> 

Olek

Re: [PULL] Networking for v6.3

[pr-tracker-bot]

The pull request you sent on Tue, 21 Feb 2023 15:38:08 -0800:

> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5b7c4cabbb65f5c469464da6c5f614cbd7f730f2

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [PULL] Networking for v6.3

[Linus Torvalds]

On Tue, Feb 21, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
--
> Networking changes for 6.3.

Hmm. I just noticed another issue on my laptop: I get an absolute *flood* of

  warning: 'ThreadPoolForeg' uses wireless extensions that are
deprecated for modern drivers: use nl80211

introduced in commit dc09766c755c ("wifi: wireless: warn on most
wireless extension usage").

This is on my xps13 with Atheros QCA6174 wireless ("Killer 1435
Wireless-AC", PCI ID 168c:003e, subsystem 1a56:143a).

And yes, it uses 'pr_warn_ratelimited()', but the ratelimiting is a
joke. That means that I "only" get five warnings a second, and then it
pauses for a minute or two until it does it again.

So that warning needs to go away - it flushed the whole kernel printk
buffer in no time.

                  Linus

Re: [PULL] Networking for v6.3

[Kalle Valo]

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Tue, Feb 21, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
> --
>> Networking changes for 6.3.
>
> Hmm. I just noticed another issue on my laptop: I get an absolute *flood* of
>
>   warning: 'ThreadPoolForeg' uses wireless extensions that are
> deprecated for modern drivers: use nl80211
>
> introduced in commit dc09766c755c ("wifi: wireless: warn on most
> wireless extension usage").
>
> This is on my xps13 with Atheros QCA6174 wireless ("Killer 1435
> Wireless-AC", PCI ID 168c:003e, subsystem 1a56:143a).
>
> And yes, it uses 'pr_warn_ratelimited()', but the ratelimiting is a
> joke. That means that I "only" get five warnings a second, and then it
> pauses for a minute or two until it does it again.
>
> So that warning needs to go away - it flushed the whole kernel printk
> buffer in no time.

Ouch, sorry about that. The ratelimiting is really a joke here. We'll
send a patch tomorrow.

So that we can file a bug report about use of Wireless Extensions, what
process is ThreadPoolForeg? I did a quick search and it seems to be
Chromium related, but is it really from Chromium? The warning was
applied over a month ago, I'm surprised nobody else has reported
anything. I would expect that there are more Chromium users :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PULL] Networking for v6.3

[Linus Torvalds]

On Thu, Feb 23, 2023 at 11:06 AM Kalle Valo <kvalo@kernel.org> wrote:
>
> So that we can file a bug report about use of Wireless Extensions, what
> process is ThreadPoolForeg?

It is, as you already seem to have googled, just a sub-thread of google-chrome.

> The warning was applied over a month ago, I'm surprised nobody
> else has reported anything.

Honestly, I'm not sure how many people actually _run_ a real desktop
on linux-next. Getting merged into mainline really ends up resulting
in a lot more testing (outside of the test robots that don't tend to
really run desktop loads).

I see it on my desktop too, but I actually noticed it on my laptop
first, because it - once again - has started falling off the wireless
network regularly and I was looking if there were any messages about
it.

(That ath driver really is flaky, and I've never figured out what the
trigger is, it just sometimes goes dead and you have to disable and
re-enable wireless. But that's not a new problem, it's just a "that's
why I noticed")

                 Linus