From: Martin KaFai Lau <martin.lau@linux.dev>
To: Jiri Olsa <olsajiri@gmail.com>, thinker.li@gmail.com
Cc: bpf@vger.kernel.org, ast@kernel.org, song@kernel.org,
kernel-team@meta.com, andrii@kernel.org, davemarchevsky@meta.com,
dvernet@meta.com, sinquersw@gmail.com, kuifeng@meta.com
Subject: Re: [PATCH bpf-next v8 3/4] bpf: Create argument information for nullable arguments.
Date: Tue, 13 Feb 2024 15:27:30 -0800 [thread overview]
Message-ID: <8e0ba6bf-1bb0-4b02-8c2f-e24383f8c8fe@linux.dev> (raw)
In-Reply-To: <ZcoEzyRzxLUWWhw4@krava>
On 2/12/24 3:45 AM, Jiri Olsa wrote:
> On Thu, Feb 08, 2024 at 06:37:49PM -0800, thinker.li@gmail.com wrote:
>
> SNIP
>
>> enum bpf_struct_ops_state {
>> @@ -1790,6 +1806,7 @@ int bpf_struct_ops_desc_init(struct bpf_struct_ops_desc *st_ops_desc,
>> struct btf *btf,
>> struct bpf_verifier_log *log);
>> void bpf_map_struct_ops_info_fill(struct bpf_map_info *info, struct bpf_map *map);
>> +void bpf_struct_ops_desc_release(struct bpf_struct_ops_desc *st_ops_desc);
>> #else
>> #define register_bpf_struct_ops(st_ops, type) ({ (void *)(st_ops); 0; })
>> static inline bool bpf_try_module_get(const void *data, struct module *owner)
>> @@ -1814,6 +1831,10 @@ static inline void bpf_map_struct_ops_info_fill(struct bpf_map_info *info, struc
>> {
>> }
>>
>> +static inline void bpf_struct_ops_desc_release(struct bpf_struct_ops_desc *st_ops_desc, int len)
>> +{
>> +}
>
> extra len argument?
Good catch. Fixed and applied. Also changed some inconsistent integer usage by
s/s32/u32/ (e.g. s/s32/u32/ arg_btf_id)
next prev parent reply other threads:[~2024-02-13 23:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 2:37 [PATCH bpf-next v8 0/4] Support PTR_MAYBE_NULL for struct_ops arguments thinker.li
2024-02-09 2:37 ` [PATCH bpf-next v8 1/4] bpf: add btf pointer to struct bpf_ctx_arg_aux thinker.li
2024-02-11 18:59 ` Martin KaFai Lau
2024-02-09 2:37 ` [PATCH bpf-next v8 2/4] bpf: Move __kfunc_param_match_suffix() to btf.c thinker.li
2024-02-09 2:37 ` [PATCH bpf-next v8 3/4] bpf: Create argument information for nullable arguments thinker.li
2024-02-11 19:49 ` Martin KaFai Lau
2024-02-12 17:09 ` Kui-Feng Lee
2024-02-12 11:45 ` Jiri Olsa
2024-02-12 17:50 ` Kui-Feng Lee
2024-02-13 23:27 ` Martin KaFai Lau [this message]
2024-02-09 2:37 ` [PATCH bpf-next v8 4/4] selftests/bpf: Test PTR_MAYBE_NULL arguments of struct_ops operators thinker.li
2024-02-13 23:30 ` [PATCH bpf-next v8 0/4] Support PTR_MAYBE_NULL for struct_ops arguments patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e0ba6bf-1bb0-4b02-8c2f-e24383f8c8fe@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davemarchevsky@meta.com \
--cc=dvernet@meta.com \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=olsajiri@gmail.com \
--cc=sinquersw@gmail.com \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox