From: Martin KaFai Lau <martin.lau@linux.dev>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: magnus.karlsson@intel.com, bjorn@kernel.org, ast@kernel.org,
daniel@iogearbox.net, netdev@vger.kernel.org,
jonathan.lemon@gmail.com, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/xsk: fix double free
Date: Thu, 29 Sep 2022 17:52:22 -0700 [thread overview]
Message-ID: <9d828483-21d0-18da-0870-babcb50d5c03@linux.dev> (raw)
In-Reply-To: <YzV28OlK+pwlm/B/@boxer>
On 9/29/22 3:44 AM, Maciej Fijalkowski wrote:
> On Thu, Sep 29, 2022 at 11:01:33AM +0200, Magnus Karlsson wrote:
>> From: Magnus Karlsson <magnus.karlsson@intel.com>
>>
>> Fix a double free at exit of the test suite.
>>
>> Fixes: a693ff3ed561 ("selftests/xsk: Add support for executing tests on physical device")
>> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
>> ---
>> tools/testing/selftests/bpf/xskxceiver.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
>> index ef33309bbe49..d1a5f3218c34 100644
>> --- a/tools/testing/selftests/bpf/xskxceiver.c
>> +++ b/tools/testing/selftests/bpf/xskxceiver.c
>> @@ -1953,9 +1953,6 @@ int main(int argc, char **argv)
>>
>> pkt_stream_delete(tx_pkt_stream_default);
>> pkt_stream_delete(rx_pkt_stream_default);
>> - free(ifobj_rx->umem);
>> - if (!ifobj_tx->shared_umem)
shared_umem means ifobj_rx->umem and ifobj_tx->umem are the same? No special
handling is needed and ifobject_delete() will handle it?
>> - free(ifobj_tx->umem);
>> ifobject_delete(ifobj_tx);
>> ifobject_delete(ifobj_rx);
>
> So basically we free this inside ifobject_delete().
next prev parent reply other threads:[~2022-09-30 0:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 9:01 [PATCH bpf-next] selftests/xsk: fix double free Magnus Karlsson
2022-09-29 10:44 ` Maciej Fijalkowski
2022-09-30 0:52 ` Martin KaFai Lau [this message]
2022-09-30 7:52 ` Magnus Karlsson
2022-09-30 14:31 ` Magnus Karlsson
2022-09-30 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d828483-21d0-18da-0870-babcb50d5c03@linux.dev \
--to=martin.lau@linux.dev \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox