BPF List
 help / color / mirror / Atom feed
From: "Emil Tsalapatis" <emil@etsalapatis.com>
To: "Hui Zhu" <hui.zhu@linux.dev>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"JP Kobryn" <inwardvessel@gmail.com>,
	"Roman Gushchin" <roman.gushchin@linux.dev>,
	<bpf@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: "Hui Zhu" <zhuhui@kylinos.cn>
Subject: Re: [PATCH bpf-next v3 0/3] Fix test_cgroup_iter_memcg issues found during back-porting
Date: Sat, 28 Feb 2026 16:26:03 -0500	[thread overview]
Message-ID: <DGQWV6Z1YV14.1I11KQX54LSOQ@etsalapatis.com> (raw)
In-Reply-To: <cover.1772261955.git.zhuhui@kylinos.cn>

On Sat Feb 28, 2026 at 2:11 AM EST, Hui Zhu wrote:
> From: Hui Zhu <zhuhui@kylinos.cn>
>
> While back-porting "mm: bpf kfuncs to access memcg data", I
> encountered issues with test_cgroup_iter_memcg, specifically
> in test_kmem.
>
> These patches are my fixes for the problems I encountered.
>

Nit: Could you be a bit more descriptive about the series' contents?
Cover letters normally focus on what what the patch does - for example
the issues being found during backporting is not pertinent to the patchset 
itself, because the issues are still present on bpf-next.

> Changelog:
> v3:
> According to the comments of JP Kobryn, remove kmem subtest from
> cgroup_iter_memcg and fix assertion string in test_pgfault.
> v2:
> According to the comments of JP Kobryn, added bpf_core_enum_value()
> usage in the BPF program to handle cross-kernel enum value differences
> at load-time instead of compile-time.
> Dropped the mm/memcontrol.c patch.
> Modified test_kmem handling: instead of skipping when nokmem is set,
> verify that kmem value is zero as expected.
> According to the comments of bot, fixed assertion message: changed
> "bpf_mem_cgroup_page_state" to "bpf_mem_cgroup_vm_events" for PGFAULT
> check.
>
> Hui Zhu (3):
>   selftests/bpf: Remove kmem subtest from cgroup_iter_memcg
>   bpf: Use bpf_core_enum_value for stats in cgroup_iter_memcg
>   selftests/bpf: Check bpf_mem_cgroup_page_state return value
>
>  .../testing/selftests/bpf/cgroup_iter_memcg.h |  2 -
>  .../bpf/prog_tests/cgroup_iter_memcg.c        | 38 +++++--------------
>  .../selftests/bpf/progs/cgroup_iter_memcg.c   | 18 ++++++---
>  3 files changed, 22 insertions(+), 36 deletions(-)


  parent reply	other threads:[~2026-02-28 21:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28  7:11 [PATCH bpf-next v3 0/3] Fix test_cgroup_iter_memcg issues found during back-porting Hui Zhu
2026-02-28  7:11 ` [PATCH bpf-next v3 1/3] selftests/bpf: Remove kmem subtest from cgroup_iter_memcg Hui Zhu
2026-02-28  7:11 ` [PATCH bpf-next v3 2/3] bpf: Use bpf_core_enum_value for stats in cgroup_iter_memcg Hui Zhu
2026-02-28  7:43   ` bot+bpf-ci
2026-02-28 21:31   ` Emil Tsalapatis
2026-02-28  7:11 ` [PATCH bpf-next v3 3/3] selftests/bpf: Check bpf_mem_cgroup_page_state return value Hui Zhu
2026-02-28 21:50   ` Emil Tsalapatis
2026-02-28 21:26 ` Emil Tsalapatis [this message]
2026-02-28 22:19   ` [PATCH bpf-next v3 0/3] Fix test_cgroup_iter_memcg issues found during back-porting Emil Tsalapatis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGQWV6Z1YV14.1I11KQX54LSOQ@etsalapatis.com \
    --to=emil@etsalapatis.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=hui.zhu@linux.dev \
    --cc=inwardvessel@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    --cc=zhuhui@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox