From: "Emil Tsalapatis" <emil@etsalapatis.com>
To: <bot+bpf-ci@kernel.org>, <emil@etsalapatis.com>, <bpf@vger.kernel.org>
Cc: <ast@kernel.org>, <andrii@kernel.org>, <memxor@gmail.com>,
<daniel@iogearbox.net>, <eddyz87@gmail.com>,
<mattbobrowski@google.com>, <song@kernel.org>,
<martin.lau@kernel.org>, <yonghong.song@linux.dev>,
<clm@meta.com>, <ihor.solodrai@linux.dev>
Subject: Re: [PATCH bpf-next 3/5] selftests/bpf: libarena: Clean up allocation state before buddy tests
Date: Tue, 23 Jun 2026 19:42:53 -0400 [thread overview]
Message-ID: <DJGTSLYKSIWE.B58OC67S6FHA@etsalapatis.com> (raw)
In-Reply-To: <52707834463b9ad1861552674b98bcb2f92d6601295548454770d883c8c43536@mail.kernel.org>
On Thu Jun 18, 2026 at 5:47 AM EDT, bot+bpf-ci wrote:
>> Summary: The buddy allocator requires the global BPF buddy allocator
>> to not be already initialized. However, the test currently merely resets
>> the allocator before the buddy tests instead of destroying it, and the
>> test worked because the buddy test happened to run first. Properly
>> destroy the allocator instead of resetting it.
>>
>> Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
>
> This looks like a bug fix for the buddy test harness, where the
> run_libarena_test()/run_libarena_asan_test() path only reset the
> allocator rather than destroying it. Should this include a Fixes: tag?
>
> Fixes: b1487dc1b181 ("selftests/bpf: Add selftests for libarena buddy allocator")
>
Not triggerable until we add the tests in this patchset.
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/27749630149
next prev parent reply other threads:[~2026-06-23 23:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 8:56 [PATCH bpf-next 0/5] selftests/bpf: libarena cleanup and bitmap struct Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 1/5] libarena/selftests: Replace leftover st_ prefix with test_ Emil Tsalapatis
2026-06-30 19:21 ` Ihor Solodrai
2026-07-01 4:23 ` Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 2/5] selftests/bpf: libarena: Fix can-loop zero variable definition Emil Tsalapatis
2026-06-18 9:09 ` sashiko-bot
2026-06-25 19:15 ` Eduard Zingerman
2026-06-30 19:28 ` Ihor Solodrai
2026-07-01 4:28 ` Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 3/5] selftests/bpf: libarena: Clean up allocation state before buddy tests Emil Tsalapatis
2026-06-18 9:47 ` bot+bpf-ci
2026-06-23 23:42 ` Emil Tsalapatis [this message]
2026-06-30 20:23 ` Ihor Solodrai
2026-06-18 8:56 ` [PATCH bpf-next 4/5] selftests/bpf: Add arena-based bitmap data structure Emil Tsalapatis
2026-06-18 9:08 ` sashiko-bot
2026-06-23 23:30 ` Emil Tsalapatis
2026-06-18 9:47 ` bot+bpf-ci
2026-06-30 21:44 ` Ihor Solodrai
2026-07-01 4:33 ` Emil Tsalapatis
2026-06-18 8:56 ` [PATCH bpf-next 5/5] selftests/bpf: libarena: Add bitmap selftets Emil Tsalapatis
2026-06-30 21:46 ` Ihor Solodrai
2026-07-01 4:33 ` Emil Tsalapatis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJGTSLYKSIWE.B58OC67S6FHA@etsalapatis.com \
--to=emil@etsalapatis.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=martin.lau@kernel.org \
--cc=mattbobrowski@google.com \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox