Re: [PATCH bpf-next 1/5] libarena/selftests: Replace leftover st_ prefix with test_

["Emil Tsalapatis" <emil@etsalapatis.com>]

On Tue Jun 30, 2026 at 3:21 PM EDT, Ihor Solodrai wrote:
> On 6/18/26 1:56 AM, Emil Tsalapatis wrote:
>> ---
>>  .../selftests/{st_asan_buddy.bpf.c => test_asan_buddy.bpf.c}    | 2 +-
>>  .../libarena/selftests/{st_asan_common.h => test_asan_common.h} | 0
>>  .../bpf/libarena/selftests/{st_buddy.bpf.c => test_buddy.bpf.c} | 0
>>  3 files changed, 1 insertion(+), 1 deletion(-)
>>  rename tools/testing/selftests/bpf/libarena/selftests/{st_asan_buddy.bpf.c => test_asan_buddy.bpf.c} (99%)
>>  rename tools/testing/selftests/bpf/libarena/selftests/{st_asan_common.h => test_asan_common.h} (100%)
>>  rename tools/testing/selftests/bpf/libarena/selftests/{st_buddy.bpf.c => test_buddy.bpf.c} (100%)
>
> Acked-by: Ihor Solodrai <ihor.solodrai@linux.dev>
>
> nit: An empty commit message is weird.
> The short message is self-explanatory here, but still...
> Maybe a brief comment on *why* this is done?

Ack, I must have a forgotten it... It's a cosmetic change to make it
more obvious what the test is.

>
>> 
>> diff --git a/tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c b/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
>> similarity index 99%
>> rename from tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c
>> rename to tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
>> index 686caba2c643..256d62a03ce7 100644
>> --- a/tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c
>> +++ b/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
>> @@ -12,7 +12,7 @@ extern struct buddy __arena buddy;
>>  
>>  #ifdef BPF_ARENA_ASAN
>>  
>> -#include "st_asan_common.h"
>> +#include "test_asan_common.h"
>>  
>>  static __always_inline int asan_test_buddy_oob_single(size_t alloc_size)
>>  {
>> diff --git a/tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h b/tools/testing/selftests/bpf/libarena/selftests/test_asan_common.h
>> similarity index 100%
>> rename from tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h
>> rename to tools/testing/selftests/bpf/libarena/selftests/test_asan_common.h
>> diff --git a/tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c b/tools/testing/selftests/bpf/libarena/selftests/test_buddy.bpf.c
>> similarity index 100%
>> rename from tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c
>> rename to tools/testing/selftests/bpf/libarena/selftests/test_buddy.bpf.c