BPF List
 help / color / mirror / Atom feed
From: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>
To: "Eduard Zingerman" <eddyz87@gmail.com>, <bpf@vger.kernel.org>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Emil Tsalapatis" <emil@etsalapatis.com>, <kkd@meta.com>,
	<kernel-team@meta.com>
Subject: Re: [PATCH bpf-next v1 2/3] selftests/bpf: Adjust veristat stack depth parsing
Date: Mon, 03 Aug 2026 00:00:04 +0200	[thread overview]
Message-ID: <DKESNO9TRIMU.3RWVUW9A1WE96@gmail.com> (raw)
In-Reply-To: <95d8960950ee42a77c2f62301cf4ffd31763fbe3.camel@gmail.com>

On Sun Aug 2, 2026 at 11:11 PM CEST, Eduard Zingerman wrote:
> On Sun, 2026-08-02 at 01:03 +0200, Kumar Kartikeya Dwivedi wrote:
>> The verifier changed the output format for stack depth verification
>> statistics. Adjust the parsing code.
>>
>> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
>> ---
>
> Do we care about backwards compatibility in veristat?
> E.g. I see it packaged in my debian system.
> This won't be able to parse the output of an old kernel.
> On the other hand, I personally do not use stack metrics,
> so the change does not really affect me.
>

It is an open question, given it is packaged, my instinct now is to parse both
formats, to cause the last amount of disruption. So that's what I'll do unless
someone tells me otherwise.

> ...


  reply	other threads:[~2026-08-02 22:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-01 23:03 [PATCH bpf-next v1 0/3] Improve stack depth verification stats output Kumar Kartikeya Dwivedi
2026-08-01 23:03 ` [PATCH bpf-next v1 1/3] bpf: Show more useful info in stack depth stats Kumar Kartikeya Dwivedi
2026-08-01 23:11   ` sashiko-bot
2026-08-01 23:15     ` Kumar Kartikeya Dwivedi
2026-08-02  0:35   ` bot+bpf-ci
2026-08-02 21:02   ` Eduard Zingerman
2026-08-02 21:59     ` Kumar Kartikeya Dwivedi
2026-08-02 22:03       ` Eduard Zingerman
2026-08-01 23:03 ` [PATCH bpf-next v1 2/3] selftests/bpf: Adjust veristat stack depth parsing Kumar Kartikeya Dwivedi
2026-08-02 21:11   ` Eduard Zingerman
2026-08-02 22:00     ` Kumar Kartikeya Dwivedi [this message]
2026-08-01 23:03 ` [PATCH bpf-next v1 3/3] selftests/bpf: Test stack depth stats without BTF subprog names Kumar Kartikeya Dwivedi
2026-08-02 21:54   ` Eduard Zingerman
2026-08-02 22:00     ` Kumar Kartikeya Dwivedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKESNO9TRIMU.3RWVUW9A1WE96@gmail.com \
    --to=memxor@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=kernel-team@meta.com \
    --cc=kkd@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox