BPF List
 help / color / mirror / Atom feed
* [PATCH bpf-next v4 0/3] libbpf: Fix CO-RE relocations of unsigned 32-bit enum values
@ 2026-11-20 16:55 Yonghong Song
  2026-11-20 16:55 ` [PATCH bpf-next v4 1/3] " Yonghong Song
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Yonghong Song @ 2026-11-20 16:55 UTC (permalink / raw)
  To: bpf
  Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann,
	Eduard Zingerman, kernel-team

For a BPF_CORE_ENUMVAL_VALUE relocation, libbpf sign-extends the value
of a 32-bit enumerator even if the enum is unsigned. A value in
[0x80000000, 0xffffffff], e.g., DCACHE_PRIVATE of enum dentry_flags,
then doesn't match the zero-extended value clang emits, and the whole
object is refused.

Patch 1 extends the value as given by the kflag of the enum, which is
the form clang emits. The kernel builds the same relo_core.c, so it gets
the fix too.

GCC emits every 32-bit enum value sign-extended, since its
__builtin_preserve_enum_value() returns int. So with the change above
alone, GCC objects that load today would be refused. Patch 1 therefore
also accepts the sign-extended form of an unsigned value, and patches
the target value in the same form.

The BTF of a kernel before v6.0, or generated by pahole before v1.24,
has the kflag 0 on every enum, signed or not, so there the kflag 0
doesn't mean unsigned. If the local enum is signed, patch 1 takes such
a target value as signed too, so that, e.g., -1 doesn't become
0xffffffff.

Patch 2 tests the unsigned enum values, with clang and GCC. Patch 3
tests the signed ones against a target BTF without the kflag.

Changelog:
  v3 -> v4:
    - v3: https://lore.kernel.org/bpf/20261119232647.3392045-1-yonghong.song@linux.dev/
    - Take a 32-bit target enum value as signed if the target enum has
      the kflag 0 but the local enum is signed, for the BTF of kernels
      without enum signedness (patch 1).
    - Test it with a target BTF whose enums have the kflag cleared
      (patch 3).
  v2 -> v3:
    - v2: https://lore.kernel.org/bpf/20261119051443.1902163-1-yonghong.song@linux.dev/
    - Fold patch 3 into patch 1 and patch 4 into patch 2 to avoid test
      failures when bisecting.
  v1 -> v2:
    - v1: https://lore.kernel.org/bpf/20261118161053.1768878-1-yonghong.song@linux.dev/
    - Accept the sign-extended enum values emitted by GCC (patch 3), and
      make the new test work with GCC (patch 4).

Yonghong Song (3):
  libbpf: Fix CO-RE relocations of unsigned 32-bit enum values
  selftests/bpf: Test CO-RE relocations of unsigned 32-bit enum values
  selftests/bpf: Test CO-RE relocations of signed enum values without
    kflag

 include/linux/btf.h                           |  5 +
 tools/lib/bpf/relo_core.c                     | 59 +++++++++++-
 .../selftests/bpf/prog_tests/core_reloc.c     | 92 ++++++++++++++++++-
 .../btf__core_reloc_enumval___no_kflag.c      |  3 +
 .../selftests/bpf/progs/core_reloc_types.h    | 24 +++++
 .../bpf/progs/test_core_reloc_enumval.c       | 35 +++++++
 6 files changed, 212 insertions(+), 6 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/btf__core_reloc_enumval___no_kflag.c

-- 
2.53.1-Meta


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-20 19:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 16:55 [PATCH bpf-next v4 0/3] libbpf: Fix CO-RE relocations of unsigned 32-bit enum values Yonghong Song
2026-11-20 16:55 ` [PATCH bpf-next v4 1/3] " Yonghong Song
2026-11-20 19:28   ` Alexei Starovoitov
2026-11-20 16:55 ` [PATCH bpf-next v4 2/3] selftests/bpf: Test " Yonghong Song
2026-11-20 16:55 ` [PATCH bpf-next v4 3/3] selftests/bpf: Test CO-RE relocations of signed enum values without kflag Yonghong Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox