From: Tejun Heo <tj@kernel.org>
To: Yonghong Song <yhs@meta.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, KP Singh <kpsingh@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next v2 3/6] libbpf: Support new cgroup local storage
Date: Fri, 21 Oct 2022 15:05:12 -1000 [thread overview]
Message-ID: <Y1NByH+suY2s65Kh@slm.duckdns.org> (raw)
In-Reply-To: <966cb96e-e0a0-aec5-1cce-a4c9fbc0ca5f@meta.com>
Hello,
On Fri, Oct 21, 2022 at 05:32:58PM -0700, Yonghong Song wrote:
> > LGTM, but I do think that BPF_MAP_TYPE_CG_STORAGE and "cg_storage" is
> > easier to read and talk about. But that's minor.
>
> I searched kernel/cgroup/* and kernel/bpf/cgroup.c and
> include/linux/cgroup*.h. The 'cgrp' for abbreviation of 'cgroup' is much
> more than
> 'cg' for 'cgroup' unless 'cg' appears in like 'memcg' or 'rdmacg'. So I
> would just use 'cgrp' for now.
Yeah, cgrp is more consistent for prefixes and variable names. cg is usually
used as a part of an abbreviated word - memcg, blkcg, cgid and so on.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-10-22 1:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 22:12 [PATCH bpf-next v2 0/6] bpf: Implement cgroup local storage available to non-cgroup-attached bpf progs Yonghong Song
2022-10-20 22:13 ` [PATCH bpf-next v2 1/6] bpf: Make struct cgroup btf id global Yonghong Song
2022-10-20 22:13 ` [PATCH bpf-next v2 2/6] bpf: Implement cgroup storage available to non-cgroup-attached bpf progs Yonghong Song
2022-10-21 5:22 ` David Vernet
2022-10-21 5:26 ` David Vernet
2022-10-21 17:33 ` Yonghong Song
2022-10-21 19:57 ` David Vernet
2022-10-21 22:57 ` Yonghong Song
2022-10-22 3:02 ` David Vernet
2022-10-23 16:45 ` Yonghong Song
2022-10-23 21:14 ` David Vernet
[not found] ` <202210210932.nHqTyTmx-lkp@intel.com>
2022-10-21 16:51 ` Yonghong Song
2022-10-21 19:29 ` Yosry Ahmed
2022-10-21 21:05 ` Yonghong Song
2022-10-20 22:13 ` [PATCH bpf-next v2 3/6] libbpf: Support new cgroup local storage Yonghong Song
2022-10-21 23:10 ` Andrii Nakryiko
2022-10-22 0:32 ` Yonghong Song
2022-10-22 1:05 ` Tejun Heo [this message]
2022-10-20 22:13 ` [PATCH bpf-next v2 4/6] bpftool: " Yonghong Song
2022-10-20 22:13 ` [PATCH bpf-next v2 5/6] selftests/bpf: Add selftests for " Yonghong Song
2022-10-20 22:13 ` [PATCH bpf-next v2 6/6] docs/bpf: Add documentation for map type BPF_MAP_TYPE_CGRP_STROAGE Yonghong Song
2022-10-21 7:12 ` David Vernet
2022-10-21 17:46 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1NByH+suY2s65Kh@slm.duckdns.org \
--to=tj@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@kernel.org \
--cc=yhs@fb.com \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox