* [PATCH] samples/seccomp: fix array_size.cocci warning
@ 2022-11-13 9:58 wangkailong
2022-11-14 17:15 ` sdf
0 siblings, 1 reply; 3+ messages in thread
From: wangkailong @ 2022-11-13 9:58 UTC (permalink / raw)
To: linux-kernel, bpf
Fix following coccicheck warning:
samples/seccomp/bpf-fancy.c:83:39-40: WARNING: Use ARRAY_SIZE
samples/seccomp/bpf-fancy.c:86:44-45: WARNING: Use ARRAY_SIZE
Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
samples/seccomp/bpf-fancy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/samples/seccomp/bpf-fancy.c b/samples/seccomp/bpf-fancy.c
index 1ccb435025b6..548f038924d6 100644
--- a/samples/seccomp/bpf-fancy.c
+++ b/samples/seccomp/bpf-fancy.c
@@ -80,10 +80,10 @@ int main(int argc, char **argv)
};
struct sock_fprog prog = {
.filter = filter,
- .len = (unsigned short)(sizeof(filter)/sizeof(filter[0])),
+ .len = (unsigned short)(ARRAY_SIZE(filter)),
};
ssize_t bytes;
- bpf_resolve_jumps(&l, filter, sizeof(filter)/sizeof(*filter));
+ bpf_resolve_jumps(&l, filter, ARRAY_SIZE(filter));
if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
perror("prctl(NO_NEW_PRIVS)");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] samples/seccomp: fix array_size.cocci warning
2022-11-13 9:58 [PATCH] samples/seccomp: fix array_size.cocci warning wangkailong
@ 2022-11-14 17:15 ` sdf
2022-11-18 0:54 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: sdf @ 2022-11-14 17:15 UTC (permalink / raw)
To: wangkailong; +Cc: linux-kernel, bpf, keescook
On 11/13, wangkailong@jari.cn wrote:
> Fix following coccicheck warning:
> samples/seccomp/bpf-fancy.c:83:39-40: WARNING: Use ARRAY_SIZE
> samples/seccomp/bpf-fancy.c:86:44-45: WARNING: Use ARRAY_SIZE
Not sure this should go via bpf tree. CC'ed Kees
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
> samples/seccomp/bpf-fancy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/samples/seccomp/bpf-fancy.c b/samples/seccomp/bpf-fancy.c
> index 1ccb435025b6..548f038924d6 100644
> --- a/samples/seccomp/bpf-fancy.c
> +++ b/samples/seccomp/bpf-fancy.c
> @@ -80,10 +80,10 @@ int main(int argc, char **argv)
> };
> struct sock_fprog prog = {
> .filter = filter,
> - .len = (unsigned short)(sizeof(filter)/sizeof(filter[0])),
> + .len = (unsigned short)(ARRAY_SIZE(filter)),
> };
> ssize_t bytes;
> - bpf_resolve_jumps(&l, filter, sizeof(filter)/sizeof(*filter));
> + bpf_resolve_jumps(&l, filter, ARRAY_SIZE(filter));
> if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
> perror("prctl(NO_NEW_PRIVS)");
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] samples/seccomp: fix array_size.cocci warning
2022-11-14 17:15 ` sdf
@ 2022-11-18 0:54 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2022-11-18 0:54 UTC (permalink / raw)
To: sdf; +Cc: wangkailong, linux-kernel, bpf
On Mon, Nov 14, 2022 at 09:15:35AM -0800, sdf@google.com wrote:
> On 11/13, wangkailong@jari.cn wrote:
> > Fix following coccicheck warning:
>
> > samples/seccomp/bpf-fancy.c:83:39-40: WARNING: Use ARRAY_SIZE
> > samples/seccomp/bpf-fancy.c:86:44-45: WARNING: Use ARRAY_SIZE
>
> Not sure this should go via bpf tree. CC'ed Kees
>
> > Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> > ---
> > samples/seccomp/bpf-fancy.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> > diff --git a/samples/seccomp/bpf-fancy.c b/samples/seccomp/bpf-fancy.c
> > index 1ccb435025b6..548f038924d6 100644
> > --- a/samples/seccomp/bpf-fancy.c
> > +++ b/samples/seccomp/bpf-fancy.c
> > @@ -80,10 +80,10 @@ int main(int argc, char **argv)
> > };
> > struct sock_fprog prog = {
> > .filter = filter,
> > - .len = (unsigned short)(sizeof(filter)/sizeof(filter[0])),
> > + .len = (unsigned short)(ARRAY_SIZE(filter)),
> > };
> > ssize_t bytes;
> > - bpf_resolve_jumps(&l, filter, sizeof(filter)/sizeof(*filter));
> > + bpf_resolve_jumps(&l, filter, ARRAY_SIZE(filter));
Hm, this is the "samples" tree, so this was intentionally avoiding these
kinds of kernel-isms, but perhaps that doesn't realistically matter?
-Kees
>
> > if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
> > perror("prctl(NO_NEW_PRIVS)");
> > --
> > 2.25.1
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-18 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-13 9:58 [PATCH] samples/seccomp: fix array_size.cocci warning wangkailong
2022-11-14 17:15 ` sdf
2022-11-18 0:54 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox