* [PATCH] xen-netback: Remove set but unused variable 'pending_idx'
@ 2022-12-09 3:40 Jiapeng Chong
2022-12-09 4:54 ` Saeed Mahameed
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-12-09 3:40 UTC (permalink / raw)
To: wei.liu
Cc: paul, davem, edumazet, kuba, pabeni, ast, daniel, hawk,
john.fastabend, xen-devel, netdev, linux-kernel, bpf,
Jiapeng Chong, Abaci Robot
Variable pending_idx is not effectively used in the function, so delete
it.
drivers/net/xen-netback/netback.c:886:7: warning: variable ‘pending_idx’ set but not used.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3399
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/xen-netback/netback.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 054ac0e897f6..19d928389473 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -883,7 +883,6 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
struct xen_netif_tx_request txfrags[XEN_NETBK_LEGACY_SLOTS_MAX];
struct xen_netif_extra_info extras[XEN_NETIF_EXTRA_TYPE_MAX-1];
unsigned int extra_count;
- u16 pending_idx;
RING_IDX idx;
int work_to_do;
unsigned int data_len;
@@ -984,7 +983,6 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
}
index = pending_index(queue->pending_cons);
- pending_idx = queue->pending_ring[index];
if (ret >= XEN_NETBK_LEGACY_SLOTS_MAX - 1 && data_len < txreq.size)
data_len = txreq.size;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen-netback: Remove set but unused variable 'pending_idx'
2022-12-09 3:40 [PATCH] xen-netback: Remove set but unused variable 'pending_idx' Jiapeng Chong
@ 2022-12-09 4:54 ` Saeed Mahameed
0 siblings, 0 replies; 2+ messages in thread
From: Saeed Mahameed @ 2022-12-09 4:54 UTC (permalink / raw)
To: Jiapeng Chong
Cc: wei.liu, paul, davem, edumazet, kuba, pabeni, ast, daniel, hawk,
john.fastabend, xen-devel, netdev, linux-kernel, bpf, Abaci Robot
On 09 Dec 11:40, Jiapeng Chong wrote:
>Variable pending_idx is not effectively used in the function, so delete
>it.
>
>drivers/net/xen-netback/netback.c:886:7: warning: variable ‘pending_idx’ set but not used.
>
>Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3399
>Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Please mark your patch clearly with [PATCH net-next] or
[PATCH net] if it's a bug fix.
Thanks for the patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-09 4:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-09 3:40 [PATCH] xen-netback: Remove set but unused variable 'pending_idx' Jiapeng Chong
2022-12-09 4:54 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox