BPF List
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Jussi Maki <joamaki@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Manu Bretelle <chantra@meta.com>, bpf <bpf@vger.kernel.org>,
	lorenzo@kernel.org
Subject: Re: xdp_bonding/xdp_bonding_redirect_multi is failing
Date: Fri, 14 Apr 2023 16:31:27 +0200	[thread overview]
Message-ID: <ZDljvzZ8N+I7CGVT@lore-desk> (raw)
In-Reply-To: <CAHn8xck_k3UCGHoEF=rwxL-bZ3u63+m_6aWSXVejjK6EKwH0Xw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

> Hi Alexei,
> 
> On Fri, Apr 14, 2023 at 3:26 AM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > is failing with:
> > test_xdp_bonding_redirect_multi:FAIL:expected packets on veth1_2
> > unexpected expected packets on veth1_2: actual 1 < expected 100
> 
> I bisected this down to:
> fccca038f3 veth: take into account device reconfiguration for xdp_features flag.
> 
> This seems to break XDP redirection from a veth device to another veth device.
> Since bonding just delegates the XDP loading to the slave devices the
> failure should
> also be reproducible with just a pair of veth devices:
> 
>  pkt -> veth1_1  <|> veth1_2 (xdp_redirect_map_multi_prog redirects)
>                   |              /
>      <- veth2_1  <|> veth2_2   <-
> 
> It seems like this is the same failure as with the xdp_do_redirect test:
> https://lore.kernel.org/bpf/ea5cda51-e8f0-2bcd-abfa-b6bf4b11d354@linux.dev/
> 
> Lorenzo: if you fix the xdp_do_redirect test, could you also check
> that xdp_bonding passes?
> 
> Cheers,
> Jussi

Hi Jussi,

sure, let me look into it.

Regards,
Lorenzo

> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2023-04-14 14:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  0:25 xdp_bonding/xdp_bonding_redirect_multi is failing Alexei Starovoitov
2023-04-14 12:57 ` Jussi Maki
2023-04-14 14:31   ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDljvzZ8N+I7CGVT@lore-desk \
    --to=lorenzo.bianconi@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=chantra@meta.com \
    --cc=daniel@iogearbox.net \
    --cc=joamaki@gmail.com \
    --cc=lorenzo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox