xdp_bonding/xdp_bonding_redirect_multi is failing

xdp_bonding/xdp_bonding_redirect_multi is failing

[Alexei Starovoitov]

Hi Jussi,

after bpf-next -> net-next merge:

test_progs -t xdp_bonding/xdp_bonding_redirect_multi

is failing with:
test_xdp_bonding_redirect_multi:FAIL:expected packets on veth1_2
unexpected expected packets on veth1_2: actual 1 < expected 100
restore_root_netns:PASS:restore_root_netns 0 nsec
restore_root_netns:PASS:restore_root_netns 0 nsec
bonding_cleanup:PASS:delete bond1 0 nsec
bonding_cleanup:PASS:delete veth1_1 0 nsec
bonding_cleanup:PASS:delete veth1_2 0 nsec
bonding_cleanup:PASS:delete ns_dst 0 nsec
#326/8   xdp_bonding/xdp_bonding_redirect_multi:FAIL
#326     xdp_bonding:FAIL

please take a look.

Re: xdp_bonding/xdp_bonding_redirect_multi is failing

[Jussi Maki]

Hi Alexei,

On Fri, Apr 14, 2023 at 3:26 AM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> is failing with:
> test_xdp_bonding_redirect_multi:FAIL:expected packets on veth1_2
> unexpected expected packets on veth1_2: actual 1 < expected 100

I bisected this down to:
fccca038f3 veth: take into account device reconfiguration for xdp_features flag.

This seems to break XDP redirection from a veth device to another veth device.
Since bonding just delegates the XDP loading to the slave devices the
failure should
also be reproducible with just a pair of veth devices:

 pkt -> veth1_1  <|> veth1_2 (xdp_redirect_map_multi_prog redirects)
                  |              /
     <- veth2_1  <|> veth2_2   <-

It seems like this is the same failure as with the xdp_do_redirect test:
https://lore.kernel.org/bpf/ea5cda51-e8f0-2bcd-abfa-b6bf4b11d354@linux.dev/

Lorenzo: if you fix the xdp_do_redirect test, could you also check
that xdp_bonding passes?

Cheers,
Jussi

Re: xdp_bonding/xdp_bonding_redirect_multi is failing

[Lorenzo Bianconi]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

> Hi Alexei,
> 
> On Fri, Apr 14, 2023 at 3:26 AM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > is failing with:
> > test_xdp_bonding_redirect_multi:FAIL:expected packets on veth1_2
> > unexpected expected packets on veth1_2: actual 1 < expected 100
> 
> I bisected this down to:
> fccca038f3 veth: take into account device reconfiguration for xdp_features flag.
> 
> This seems to break XDP redirection from a veth device to another veth device.
> Since bonding just delegates the XDP loading to the slave devices the
> failure should
> also be reproducible with just a pair of veth devices:
> 
>  pkt -> veth1_1  <|> veth1_2 (xdp_redirect_map_multi_prog redirects)
>                   |              /
>      <- veth2_1  <|> veth2_2   <-
> 
> It seems like this is the same failure as with the xdp_do_redirect test:
> https://lore.kernel.org/bpf/ea5cda51-e8f0-2bcd-abfa-b6bf4b11d354@linux.dev/
> 
> Lorenzo: if you fix the xdp_do_redirect test, could you also check
> that xdp_bonding passes?
> 
> Cheers,
> Jussi

Hi Jussi,

sure, let me look into it.

Regards,
Lorenzo

> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]