* [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64
@ 2023-04-28 3:47 Martin KaFai Lau
2023-04-28 4:40 ` Manu Bretelle
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Martin KaFai Lau @ 2023-04-28 3:47 UTC (permalink / raw)
To: bpf
Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann, kernel-team,
Manu Bretelle
From: Martin KaFai Lau <martin.lau@kernel.org>
It is reported that the fexit_sleep never returns in aarch64.
The remaining tests cannot start. Put this test into DENYLIST.aarch64
for now so that other tests can continue to run in the CI.
Reported-by: Manu Bretelle <chantra@meta.com>
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
---
tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
index 4b6b18424140..cd42e2825bd2 100644
--- a/tools/testing/selftests/bpf/DENYLIST.aarch64
+++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
@@ -1,5 +1,6 @@
bpf_cookie/multi_kprobe_attach_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
bpf_cookie/multi_kprobe_link_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
+fexit_sleep # The test never returns. The remaining tests cannot start.
kprobe_multi_bench_attach # bpf_program__attach_kprobe_multi_opts unexpected error: -95
kprobe_multi_test/attach_api_addrs # bpf_program__attach_kprobe_multi_opts unexpected error: -95
kprobe_multi_test/attach_api_pattern # bpf_program__attach_kprobe_multi_opts unexpected error: -95
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64
2023-04-28 3:47 [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64 Martin KaFai Lau
@ 2023-04-28 4:40 ` Manu Bretelle
2023-04-28 5:10 ` patchwork-bot+netdevbpf
2023-04-28 5:51 ` Manu Bretelle
2 siblings, 0 replies; 6+ messages in thread
From: Manu Bretelle @ 2023-04-28 4:40 UTC (permalink / raw)
To: Martin KaFai Lau
Cc: bpf, Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann,
kernel-team, Manu Bretelle
On Thu, Apr 27, 2023 at 08:47:26PM -0700, Martin KaFai Lau wrote:
> From: Martin KaFai Lau <martin.lau@kernel.org>
>
> It is reported that the fexit_sleep never returns in aarch64.
> The remaining tests cannot start. Put this test into DENYLIST.aarch64
> for now so that other tests can continue to run in the CI.
>
Thanks
> Reported-by: Manu Bretelle <chantra@meta.com>
> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
> ---
> tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
> index 4b6b18424140..cd42e2825bd2 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
> +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
> @@ -1,5 +1,6 @@
> bpf_cookie/multi_kprobe_attach_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> bpf_cookie/multi_kprobe_link_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> +fexit_sleep # The test never returns. The remaining tests cannot start.
> kprobe_multi_bench_attach # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> kprobe_multi_test/attach_api_addrs # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> kprobe_multi_test/attach_api_pattern # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> --
> 2.34.1
>
Acked-by: Manu Bretelle <chantr4@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64
2023-04-28 3:47 [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64 Martin KaFai Lau
2023-04-28 4:40 ` Manu Bretelle
@ 2023-04-28 5:10 ` patchwork-bot+netdevbpf
2023-04-28 5:51 ` Manu Bretelle
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-28 5:10 UTC (permalink / raw)
To: Martin KaFai Lau; +Cc: bpf, ast, andrii, daniel, kernel-team, chantra
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Thu, 27 Apr 2023 20:47:26 -0700 you wrote:
> From: Martin KaFai Lau <martin.lau@kernel.org>
>
> It is reported that the fexit_sleep never returns in aarch64.
> The remaining tests cannot start. Put this test into DENYLIST.aarch64
> for now so that other tests can continue to run in the CI.
>
> Reported-by: Manu Bretelle <chantra@meta.com>
> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
>
> [...]
Here is the summary with links:
- [bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64
https://git.kernel.org/bpf/bpf-next/c/af781ba682e8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64
2023-04-28 3:47 [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64 Martin KaFai Lau
2023-04-28 4:40 ` Manu Bretelle
2023-04-28 5:10 ` patchwork-bot+netdevbpf
@ 2023-04-28 5:51 ` Manu Bretelle
2023-04-28 11:07 ` Daniel Borkmann
2 siblings, 1 reply; 6+ messages in thread
From: Manu Bretelle @ 2023-04-28 5:51 UTC (permalink / raw)
To: Martin KaFai Lau
Cc: bpf, Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann,
kernel-team, Manu Bretelle
On Thu, Apr 27, 2023 at 08:47:26PM -0700, Martin KaFai Lau wrote:
> From: Martin KaFai Lau <martin.lau@kernel.org>
>
> It is reported that the fexit_sleep never returns in aarch64.
Just to clarify, this was only happening against kernels compiled with
llvm-16. It was working fine against kernel compiled with gcc.
> The remaining tests cannot start. Put this test into DENYLIST.aarch64
> for now so that other tests can continue to run in the CI.
>
> Reported-by: Manu Bretelle <chantra@meta.com>
> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
> ---
> tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
> index 4b6b18424140..cd42e2825bd2 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
> +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
> @@ -1,5 +1,6 @@
> bpf_cookie/multi_kprobe_attach_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> bpf_cookie/multi_kprobe_link_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> +fexit_sleep # The test never returns. The remaining tests cannot start.
> kprobe_multi_bench_attach # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> kprobe_multi_test/attach_api_addrs # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> kprobe_multi_test/attach_api_pattern # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64
2023-04-28 5:51 ` Manu Bretelle
@ 2023-04-28 11:07 ` Daniel Borkmann
2023-04-28 12:09 ` Florent Revest
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2023-04-28 11:07 UTC (permalink / raw)
To: Manu Bretelle, Martin KaFai Lau
Cc: bpf, Alexei Starovoitov, Andrii Nakryiko, kernel-team,
Manu Bretelle, revest
On 4/28/23 7:51 AM, Manu Bretelle wrote:
> On Thu, Apr 27, 2023 at 08:47:26PM -0700, Martin KaFai Lau wrote:
>> From: Martin KaFai Lau <martin.lau@kernel.org>
>>
>> It is reported that the fexit_sleep never returns in aarch64.
>
> Just to clarify, this was only happening against kernels compiled with
> llvm-16. It was working fine against kernel compiled with gcc.
>
>> The remaining tests cannot start. Put this test into DENYLIST.aarch64
>> for now so that other tests can continue to run in the CI.
+Florent (for visibility and/or if you plan to look into it)
>> Reported-by: Manu Bretelle <chantra@meta.com>
>> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
>> ---
>> tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
>> index 4b6b18424140..cd42e2825bd2 100644
>> --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
>> +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
>> @@ -1,5 +1,6 @@
>> bpf_cookie/multi_kprobe_attach_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
>> bpf_cookie/multi_kprobe_link_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
>> +fexit_sleep # The test never returns. The remaining tests cannot start.
>> kprobe_multi_bench_attach # bpf_program__attach_kprobe_multi_opts unexpected error: -95
>> kprobe_multi_test/attach_api_addrs # bpf_program__attach_kprobe_multi_opts unexpected error: -95
>> kprobe_multi_test/attach_api_pattern # bpf_program__attach_kprobe_multi_opts unexpected error: -95
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64
2023-04-28 11:07 ` Daniel Borkmann
@ 2023-04-28 12:09 ` Florent Revest
0 siblings, 0 replies; 6+ messages in thread
From: Florent Revest @ 2023-04-28 12:09 UTC (permalink / raw)
To: Daniel Borkmann
Cc: Manu Bretelle, Martin KaFai Lau, bpf, Alexei Starovoitov,
Andrii Nakryiko, kernel-team, Manu Bretelle
On Fri, Apr 28, 2023 at 1:08 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 4/28/23 7:51 AM, Manu Bretelle wrote:
> > On Thu, Apr 27, 2023 at 08:47:26PM -0700, Martin KaFai Lau wrote:
> >> From: Martin KaFai Lau <martin.lau@kernel.org>
> >>
> >> It is reported that the fexit_sleep never returns in aarch64.
> >
> > Just to clarify, this was only happening against kernels compiled with
> > llvm-16. It was working fine against kernel compiled with gcc.
> >
> >> The remaining tests cannot start. Put this test into DENYLIST.aarch64
> >> for now so that other tests can continue to run in the CI.
>
> +Florent (for visibility and/or if you plan to look into it)
Ah, thanks for the quick fix Martin & Manu! :) It's an interesting
failure mode, I'll try to have a look at it when I get a chance. (I've
had my eyes set on the other failing selftests already :) one more
eheh)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-28 12:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-28 3:47 [PATCH bpf-next] selftests/bpf: Add fexit_sleep to DENYLIST.aarch64 Martin KaFai Lau
2023-04-28 4:40 ` Manu Bretelle
2023-04-28 5:10 ` patchwork-bot+netdevbpf
2023-04-28 5:51 ` Manu Bretelle
2023-04-28 11:07 ` Daniel Borkmann
2023-04-28 12:09 ` Florent Revest
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox