* [PATCH] bpf: Fix the comment for bpf_restore_data_end()
@ 2023-10-05 7:21 Akihiko Odaki
2023-10-05 16:53 ` Stanislav Fomichev
2023-10-06 5:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Akihiko Odaki @ 2023-10-05 7:21 UTC (permalink / raw)
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, bpf,
linux-kernel, Akihiko Odaki
The comment used to say:
> Restore data saved by bpf_compute_data_pointers().
But bpf_compute_data_pointers() does not save the data;
bpf_compute_and_save_data_end() does.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
include/linux/filter.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/filter.h b/include/linux/filter.h
index 761af6b3cf2b..bf7ad887943c 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -694,7 +694,7 @@ static inline void bpf_compute_and_save_data_end(
cb->data_end = skb->data + skb_headlen(skb);
}
-/* Restore data saved by bpf_compute_data_pointers(). */
+/* Restore data saved by bpf_compute_and_save_data_end(). */
static inline void bpf_restore_data_end(
struct sk_buff *skb, void *saved_data_end)
{
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bpf: Fix the comment for bpf_restore_data_end()
2023-10-05 7:21 [PATCH] bpf: Fix the comment for bpf_restore_data_end() Akihiko Odaki
@ 2023-10-05 16:53 ` Stanislav Fomichev
2023-10-06 5:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Stanislav Fomichev @ 2023-10-05 16:53 UTC (permalink / raw)
To: Akihiko Odaki
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Hao Luo, Jiri Olsa, bpf, linux-kernel
On 10/05, Akihiko Odaki wrote:
> The comment used to say:
> > Restore data saved by bpf_compute_data_pointers().
>
> But bpf_compute_data_pointers() does not save the data;
> bpf_compute_and_save_data_end() does.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Please use [PATCH bpf-next] (or bpf, depending on the tree) for bpf
patches in the future.
Acked-by: Stanislav Fomichev <sdf@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: Fix the comment for bpf_restore_data_end()
2023-10-05 7:21 [PATCH] bpf: Fix the comment for bpf_restore_data_end() Akihiko Odaki
2023-10-05 16:53 ` Stanislav Fomichev
@ 2023-10-06 5:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-06 5:40 UTC (permalink / raw)
To: Akihiko Odaki
Cc: ast, daniel, andrii, martin.lau, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Thu, 5 Oct 2023 16:21:36 +0900 you wrote:
> The comment used to say:
> > Restore data saved by bpf_compute_data_pointers().
>
> But bpf_compute_data_pointers() does not save the data;
> bpf_compute_and_save_data_end() does.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>
> [...]
Here is the summary with links:
- bpf: Fix the comment for bpf_restore_data_end()
https://git.kernel.org/bpf/bpf-next/c/9c8c3fa3a52b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-06 5:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-05 7:21 [PATCH] bpf: Fix the comment for bpf_restore_data_end() Akihiko Odaki
2023-10-05 16:53 ` Stanislav Fomichev
2023-10-06 5:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox