public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: andrii.nakryiko@gmail.com, jolsa@kernel.org, ast@kernel.org,
	daniel@iogearbox.net, eddyz87@gmail.com, martin.lau@linux.dev,
	song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
	kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
	mykolal@fb.com, bpf@vger.kernel.org
Subject: Re: [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features
Date: Wed, 25 Oct 2023 15:18:38 -0300	[thread overview]
Message-ID: <ZTlb/inSUnEelTJT@kernel.org> (raw)
In-Reply-To: <ZTlTpYYVoYL0fls7@kernel.org>

Em Wed, Oct 25, 2023 at 02:43:02PM -0300, Arnaldo Carvalho de Melo escreveu:
> $ cp vmlinux.v5.19.0-rc5+ vmlinux.v5.19.0-rc5+.enum64 ; pahole --btf_encode --btf_features=enum64 vmlinux.v5.19.0-rc5+.enum64 
> $
 
> I tried using --btf_encode_detached=file but then couldn't find a way to
> make 'bpftool btf' to consume detached BTF, it seems that "file" means
> "ELF file containing BTF" so I copied the original file to then reencode
> BTF selecting just the enum64 feature, the resulting file continues to
> have the original DWARF and the BTF using that --btf_features set:

This was another symptom of me using a random old bpftool, using
upstream I get what is expected:

$ pahole --btf_encode_detached=vmlinux.v5.19.0-rc5+.enum64 --btf_features=enum64 vmlinux.v5.19.0-rc5+
$ bpftool btf dump file vmlinux.v5.19.0-rc5+.enum64 format raw | wc -l
290975
$ file vmlinux.v5.19.0-rc5+.enum64
vmlinux.v5.19.0-rc5+.enum64: data
$
[acme@quaco pahole]$ bpftool btf dump file vmlinux.v5.19.0-rc5+.enum64 format raw | grep -w ENUM64
[4266] ENUM64 'perf_event_sample_format' encoding=UNSIGNED size=8 vlen=27
[5089] ENUM64 '(anon)' encoding=UNSIGNED size=8 vlen=11
[6727] ENUM64 '(anon)' encoding=SIGNED size=8 vlen=28
[27943] ENUM64 '(anon)' encoding=UNSIGNED size=8 vlen=3
[31242] ENUM64 'netdev_priv_flags' encoding=UNSIGNED size=8 vlen=33
[31438] ENUM64 'perf_callchain_context' encoding=UNSIGNED size=8 vlen=7
[38853] ENUM64 'hmm_pfn_flags' encoding=UNSIGNED size=8 vlen=7
[56830] ENUM64 'ib_uverbs_device_cap_flags' encoding=UNSIGNED size=8 vlen=25
[60295] ENUM64 'blake2b_iv' encoding=UNSIGNED size=8 vlen=8
[63498] ENUM64 '(anon)' encoding=UNSIGNED size=8 vlen=31
[93914] ENUM64 '(anon)' encoding=SIGNED size=8 vlen=172
[acme@quaco pahole]$

So sorry for the noise about this.

- Arnaldo

      parent reply	other threads:[~2023-10-25 18:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  9:57 [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features Alan Maguire
2023-10-23  9:57 ` [PATCH v4 dwarves 1/5] btf_encoder, pahole: move btf encoding options into conf_load Alan Maguire
2023-10-23  9:57 ` [PATCH v4 dwarves 2/5] dwarves: move ARRAY_SIZE() to dwarves.h Alan Maguire
2023-10-23  9:57 ` [PATCH v4 dwarves 3/5] pahole: add --btf_features support Alan Maguire
2023-10-23  9:57 ` [PATCH v4 dwarves 4/5] pahole: add --supported_btf_features Alan Maguire
2023-10-23  9:57 ` [PATCH v4 dwarves 5/5] pahole: add --btf_features_strict to reject unknown BTF features Alan Maguire
2023-10-25 17:43 ` [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features Arnaldo Carvalho de Melo
2023-10-25 17:48   ` Arnaldo Carvalho de Melo
2023-10-25 18:12     ` Arnaldo Carvalho de Melo
2023-10-25 18:30       ` Arnaldo Carvalho de Melo
2023-10-25 22:28         ` Eduard Zingerman
2023-10-26 22:06           ` Andrii Nakryiko
2023-10-27 13:25             ` Arnaldo Carvalho de Melo
2023-10-27 14:24             ` RCU stall issues in bpf-next (was: Re: [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features) Alan Maguire
2023-10-27 19:54               ` Jiri Olsa
2023-10-25 18:18   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTlb/inSUnEelTJT@kernel.org \
    --to=acme@kernel.org \
    --cc=alan.maguire@oracle.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox