From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Eduard Zingerman <eddyz87@gmail.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Alan Maguire <alan.maguire@oracle.com>,
Jiri Olsa <jolsa@kernel.org>,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
mykolal@fb.com, bpf@vger.kernel.org
Subject: Re: [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features
Date: Fri, 27 Oct 2023 10:25:07 -0300 [thread overview]
Message-ID: <ZTu6M99GZL+4UzGG@kernel.org> (raw)
In-Reply-To: <CAEf4BzbM20uErJ8-UiRb3WCxXJUXtvSRCKSfuAURXpsHU4ud-w@mail.gmail.com>
Em Thu, Oct 26, 2023 at 03:06:15PM -0700, Andrii Nakryiko escreveu:
> On Wed, Oct 25, 2023 at 3:28 PM Eduard Zingerman <eddyz87@gmail.com> wrote:
> >
> > On Wed, 2023-10-25 at 15:30 -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Wed, Oct 25, 2023 at 03:12:49PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > But I guess the acks/reviews + my tests are enough to merge this as-is,
> > > > thanks for your work on this!
> > >
> > > Ok, its in the 'next' branch so that it can go thru:
> > >
> > > https://github.com/libbpf/libbpf/actions/workflows/pahole.yml
> > >
> > > But the previous days are all failures, probably something else is
> > > preventing this test from succeeding? Andrii?
> >
> > It looks like the latest run succeeded, while a number of previous
> > runs got locked up for some reason. All using the same kernel
> > checkpoint commit. I know how to setup local github runner,
> > so I can try to replicate this by forking the repo,
> > redirecting CI to my machine and executing it several times.
> > Will do this over the weekend, need to work on some verifier
> > bugs first.
> >
>
> BPF selftests are extremely unreliable under slow Github runners,
> unfortunately. Kernel either crashes or locks up very frequently. It
> has nothing to do with libbpf and we don't seem to see this in BPF CI
> due to having much faster runners there.
>
> I'm not sure what to do about this apart from trying to identify a
> selftest that causes lock up (extremely time consuming endeavor) or
> just wait till libbpf CI will be privileged enough to gain its own
> fast AWS-based worker :)
>
> But it seems like the last scheduled run succeeded, I think you are good.
I'm not sure it got the btf_features patch, I'll try to change the cmake
files to print the HEAD so that when looking at the output in the github
actions I can be sure that it is using what needs to be tested.
- Arnaldo
next prev parent reply other threads:[~2023-10-27 13:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 9:57 [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features Alan Maguire
2023-10-23 9:57 ` [PATCH v4 dwarves 1/5] btf_encoder, pahole: move btf encoding options into conf_load Alan Maguire
2023-10-23 9:57 ` [PATCH v4 dwarves 2/5] dwarves: move ARRAY_SIZE() to dwarves.h Alan Maguire
2023-10-23 9:57 ` [PATCH v4 dwarves 3/5] pahole: add --btf_features support Alan Maguire
2023-10-23 9:57 ` [PATCH v4 dwarves 4/5] pahole: add --supported_btf_features Alan Maguire
2023-10-23 9:57 ` [PATCH v4 dwarves 5/5] pahole: add --btf_features_strict to reject unknown BTF features Alan Maguire
2023-10-25 17:43 ` [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features Arnaldo Carvalho de Melo
2023-10-25 17:48 ` Arnaldo Carvalho de Melo
2023-10-25 18:12 ` Arnaldo Carvalho de Melo
2023-10-25 18:30 ` Arnaldo Carvalho de Melo
2023-10-25 22:28 ` Eduard Zingerman
2023-10-26 22:06 ` Andrii Nakryiko
2023-10-27 13:25 ` Arnaldo Carvalho de Melo [this message]
2023-10-27 14:24 ` RCU stall issues in bpf-next (was: Re: [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features) Alan Maguire
2023-10-27 19:54 ` Jiri Olsa
2023-10-25 18:18 ` [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTu6M99GZL+4UzGG@kernel.org \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox