From: Jiri Olsa <olsajiri@gmail.com>
To: Geliang Tang <geliang@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [bpf-next] selftests/bpf: Drop return in bpf_testmod_exit
Date: Sat, 27 Jan 2024 15:41:38 +0100 [thread overview]
Message-ID: <ZbUWIioaQ-WDKTxE@krava> (raw)
In-Reply-To: <fb088aab7eee941cc6018249a47f60b0871141ea.1706349508.git.tanggeliang@kylinos.cn>
On Sat, Jan 27, 2024 at 06:02:29PM +0800, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> bpf_testmod_exit() should not have a return value, so this patch drops this
> useless 'return' in it.
>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
please rebase on top of latest bpf-next/master,
there's conflict now with latest change
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
> index 91907b321f91..e75e651f1337 100644
> --- a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
> +++ b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
> @@ -544,7 +544,7 @@ static int bpf_testmod_init(void)
>
> static void bpf_testmod_exit(void)
> {
> - return sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
> + sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
> }
>
> module_init(bpf_testmod_init);
> --
> 2.40.1
>
>
prev parent reply other threads:[~2024-01-27 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 10:02 [bpf-next] selftests/bpf: Drop return in bpf_testmod_exit Geliang Tang
2024-01-27 14:41 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbUWIioaQ-WDKTxE@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=geliang@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox