* [bpf-next] selftests/bpf: Drop return in bpf_testmod_exit
@ 2024-01-27 10:02 Geliang Tang
2024-01-27 14:41 ` Jiri Olsa
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2024-01-27 10:02 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song
Cc: Geliang Tang, bpf, linux-kselftest
From: Geliang Tang <tanggeliang@kylinos.cn>
bpf_testmod_exit() should not have a return value, so this patch drops this
useless 'return' in it.
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
index 91907b321f91..e75e651f1337 100644
--- a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
+++ b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
@@ -544,7 +544,7 @@ static int bpf_testmod_init(void)
static void bpf_testmod_exit(void)
{
- return sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
+ sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
}
module_init(bpf_testmod_init);
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [bpf-next] selftests/bpf: Drop return in bpf_testmod_exit
2024-01-27 10:02 [bpf-next] selftests/bpf: Drop return in bpf_testmod_exit Geliang Tang
@ 2024-01-27 14:41 ` Jiri Olsa
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Olsa @ 2024-01-27 14:41 UTC (permalink / raw)
To: Geliang Tang
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, Geliang Tang, bpf,
linux-kselftest
On Sat, Jan 27, 2024 at 06:02:29PM +0800, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> bpf_testmod_exit() should not have a return value, so this patch drops this
> useless 'return' in it.
>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
please rebase on top of latest bpf-next/master,
there's conflict now with latest change
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
> index 91907b321f91..e75e651f1337 100644
> --- a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
> +++ b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
> @@ -544,7 +544,7 @@ static int bpf_testmod_init(void)
>
> static void bpf_testmod_exit(void)
> {
> - return sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
> + sysfs_remove_bin_file(kernel_kobj, &bin_attr_bpf_testmod_file);
> }
>
> module_init(bpf_testmod_init);
> --
> 2.40.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-27 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-27 10:02 [bpf-next] selftests/bpf: Drop return in bpf_testmod_exit Geliang Tang
2024-01-27 14:41 ` Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox