From: Matthew Wilcox <willy@infradead.org>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, adobriyan@gmail.com,
shakeel.butt@linux.dev, hannes@cmpxchg.org, ak@linux.intel.com,
osandov@osandov.com, song@kernel.org, jannh@google.com
Subject: Re: [PATCH v3 bpf-next 02/10] lib/buildid: add single page-based file reader abstraction
Date: Wed, 7 Aug 2024 16:28:53 +0100 [thread overview]
Message-ID: <ZrOStYOrlFr21jRc@casper.infradead.org> (raw)
In-Reply-To: <20240730203914.1182569-3-andrii@kernel.org>
On Tue, Jul 30, 2024 at 01:39:06PM -0700, Andrii Nakryiko wrote:
> + union {
> + struct {
> + struct address_space *mapping;
> + struct page *page;
NAK. All the page-based interfaces are deprecated. Only we can't mark
them as deprecated because our tooling is a pile of crap.
> + void *page_addr;
> + u64 file_off;
loff_t pos.
> + r->page = find_get_page(r->mapping, pg_off);
r->folio = read_mapping_folio(r->mapping, r->pos / PAGE_SIZE, ...)
OK, for network filesystems, you're going to need to retain the struct
file that's used to access them. So maybe this becomes
read_mapping_folio(r->file->f_mapping, r->pos, r->file)
> + r->page_addr = kmap_local_page(r->page);
kmap_local_folio(r->folio, offset_in_folio(r->folio, r->pos));
next prev parent reply other threads:[~2024-08-07 15:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 20:39 [PATCH v3 bpf-next 00/10] Harden and extend ELF build ID parsing logic Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 01/10] lib/buildid: harden " Andrii Nakryiko
2024-07-31 4:04 ` Andi Kleen
2024-07-31 21:54 ` Andrii Nakryiko
2024-08-07 15:11 ` Jann Horn
2024-08-07 16:47 ` Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 02/10] lib/buildid: add single page-based file reader abstraction Andrii Nakryiko
2024-08-07 15:28 ` Matthew Wilcox [this message]
2024-08-07 17:19 ` Shakeel Butt
2024-08-07 17:46 ` Matthew Wilcox
2024-08-07 17:54 ` Shakeel Butt
2024-08-07 20:53 ` Shakeel Butt
2024-08-07 23:43 ` Andrii Nakryiko
2024-08-07 23:14 ` Andi Kleen
2024-07-30 20:39 ` [PATCH v3 bpf-next 03/10] lib/buildid: take into account e_phoff when fetching program headers Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 04/10] lib/buildid: remove single-page limit for PHDR search Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 05/10] lib/buildid: rename build_id_parse() into build_id_parse_nofault() Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 06/10] lib/buildid: implement sleepable build_id_parse() API Andrii Nakryiko
2024-07-31 21:56 ` Andrii Nakryiko
2024-08-05 18:30 ` Shakeel Butt
2024-07-30 20:39 ` [PATCH v3 bpf-next 07/10] lib/buildid: don't limit .note.gnu.build-id to the first page in ELF Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 08/10] bpf: decouple stack_map_get_build_id_offset() from perf_callchain_entry Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 09/10] bpf: wire up sleepable bpf_get_stack() and bpf_get_task_stack() helpers Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 10/10] selftests/bpf: add build ID tests Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrOStYOrlFr21jRc@casper.infradead.org \
--to=willy@infradead.org \
--cc=adobriyan@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=osandov@osandov.com \
--cc=shakeel.butt@linux.dev \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox