From: Andi Kleen <ak@linux.intel.com>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Matthew Wilcox <willy@infradead.org>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, adobriyan@gmail.com,
hannes@cmpxchg.org, osandov@osandov.com, song@kernel.org,
jannh@google.com
Subject: Re: [PATCH v3 bpf-next 02/10] lib/buildid: add single page-based file reader abstraction
Date: Wed, 7 Aug 2024 16:14:03 -0700 [thread overview]
Message-ID: <ZrP_u7V-o5VeOCBs@tassilo> (raw)
In-Reply-To: <n2y5rk74ynongpvbpbsnjzghskmw337bexf2ftcf2fnrgk3knn@3u322cnvwpcm>
> Failure is fine if there is no folio or the folio is not uptodate. I
> assume we can do:
>
> folio = __filemap_get_folio(r->mapping, pg_off, 0, 0);
> if (!folio || !folio_test_uptodate(folio))
> return -EFAULT;
>
> Is this appropriate here?
Yes EFAULTing is fine for this usage.
-Andi
next prev parent reply other threads:[~2024-08-07 23:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 20:39 [PATCH v3 bpf-next 00/10] Harden and extend ELF build ID parsing logic Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 01/10] lib/buildid: harden " Andrii Nakryiko
2024-07-31 4:04 ` Andi Kleen
2024-07-31 21:54 ` Andrii Nakryiko
2024-08-07 15:11 ` Jann Horn
2024-08-07 16:47 ` Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 02/10] lib/buildid: add single page-based file reader abstraction Andrii Nakryiko
2024-08-07 15:28 ` Matthew Wilcox
2024-08-07 17:19 ` Shakeel Butt
2024-08-07 17:46 ` Matthew Wilcox
2024-08-07 17:54 ` Shakeel Butt
2024-08-07 20:53 ` Shakeel Butt
2024-08-07 23:43 ` Andrii Nakryiko
2024-08-07 23:14 ` Andi Kleen [this message]
2024-07-30 20:39 ` [PATCH v3 bpf-next 03/10] lib/buildid: take into account e_phoff when fetching program headers Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 04/10] lib/buildid: remove single-page limit for PHDR search Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 05/10] lib/buildid: rename build_id_parse() into build_id_parse_nofault() Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 06/10] lib/buildid: implement sleepable build_id_parse() API Andrii Nakryiko
2024-07-31 21:56 ` Andrii Nakryiko
2024-08-05 18:30 ` Shakeel Butt
2024-07-30 20:39 ` [PATCH v3 bpf-next 07/10] lib/buildid: don't limit .note.gnu.build-id to the first page in ELF Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 08/10] bpf: decouple stack_map_get_build_id_offset() from perf_callchain_entry Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 09/10] bpf: wire up sleepable bpf_get_stack() and bpf_get_task_stack() helpers Andrii Nakryiko
2024-07-30 20:39 ` [PATCH v3 bpf-next 10/10] selftests/bpf: add build ID tests Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrP_u7V-o5VeOCBs@tassilo \
--to=ak@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=osandov@osandov.com \
--cc=shakeel.butt@linux.dev \
--cc=song@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox