* [PATCH -next] bpf: Use sockfd_put() helper
@ 2024-08-29 8:50 Jinjie Ruan
2024-08-29 21:15 ` Stanislav Fomichev
0 siblings, 1 reply; 3+ messages in thread
From: Jinjie Ruan @ 2024-08-29 8:50 UTC (permalink / raw)
To: ast, daniel, andrii, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf
Cc: ruanjinjie
Replace fput() with sockfd_put() in bpf_fd_reuseport_array_update_elem().
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
kernel/bpf/reuseport_array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/reuseport_array.c b/kernel/bpf/reuseport_array.c
index 4b4f9670f1a9..49b8e5a0c6b4 100644
--- a/kernel/bpf/reuseport_array.c
+++ b/kernel/bpf/reuseport_array.c
@@ -308,7 +308,7 @@ int bpf_fd_reuseport_array_update_elem(struct bpf_map *map, void *key,
spin_unlock_bh(&reuseport_lock);
put_file:
- fput(socket->file);
+ sockfd_put(socket);
return err;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] bpf: Use sockfd_put() helper
2024-08-29 8:50 [PATCH -next] bpf: Use sockfd_put() helper Jinjie Ruan
@ 2024-08-29 21:15 ` Stanislav Fomichev
2024-08-30 1:18 ` Jinjie Ruan
0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Fomichev @ 2024-08-29 21:15 UTC (permalink / raw)
To: Jinjie Ruan
Cc: ast, daniel, andrii, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, haoluo, jolsa, bpf
On 08/29, Jinjie Ruan wrote:
> Replace fput() with sockfd_put() in bpf_fd_reuseport_array_update_elem().
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Can you resend with a proper [PATCH bpf-next] tag?
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] bpf: Use sockfd_put() helper
2024-08-29 21:15 ` Stanislav Fomichev
@ 2024-08-30 1:18 ` Jinjie Ruan
0 siblings, 0 replies; 3+ messages in thread
From: Jinjie Ruan @ 2024-08-30 1:18 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: ast, daniel, andrii, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, haoluo, jolsa, bpf
On 2024/8/30 5:15, Stanislav Fomichev wrote:
> On 08/29, Jinjie Ruan wrote:
>> Replace fput() with sockfd_put() in bpf_fd_reuseport_array_update_elem().
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>
> Can you resend with a proper [PATCH bpf-next] tag?
Sure.
>
> Acked-by: Stanislav Fomichev <sdf@fomichev.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-30 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 8:50 [PATCH -next] bpf: Use sockfd_put() helper Jinjie Ruan
2024-08-29 21:15 ` Stanislav Fomichev
2024-08-30 1:18 ` Jinjie Ruan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox