* [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook
@ 2024-10-05 0:06 Thomas Weißschuh
2024-10-05 0:19 ` Song Liu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Weißschuh @ 2024-10-05 0:06 UTC (permalink / raw)
To: KP Singh, Matt Bobrowski, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
Yonghong Song, John Fastabend, Stanislav Fomichev, Hao Luo,
Jiri Olsa, Casey Schaufler, Paul Moore, John Johansen
Cc: bpf, linux-kernel, Thomas Weißschuh
The key_free LSM hook has been removed.
Remove the corresponding BPF hook.
Avoid warnings during the build:
BTFIDS vmlinux
WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free
Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
I don't know much about LSMs, so please disregard if this is wrong.
---
kernel/bpf/bpf_lsm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c
index 6292ac5f9bd139dafb39ecd8bb180be46cd7c7fd..3bc61628ab251e05d7837eb27dabc3b62bcc4783 100644
--- a/kernel/bpf/bpf_lsm.c
+++ b/kernel/bpf/bpf_lsm.c
@@ -339,10 +339,6 @@ BTF_ID(func, bpf_lsm_path_chmod)
BTF_ID(func, bpf_lsm_path_chown)
#endif /* CONFIG_SECURITY_PATH */
-#ifdef CONFIG_KEYS
-BTF_ID(func, bpf_lsm_key_free)
-#endif /* CONFIG_KEYS */
-
BTF_ID(func, bpf_lsm_mmap_file)
BTF_ID(func, bpf_lsm_netlink_send)
BTF_ID(func, bpf_lsm_path_notify)
---
base-commit: 0c559323bbaabee7346c12e74b497e283aaafef5
change-id: 20241005-lsm-key_free-b47445ee523d
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook
2024-10-05 0:06 [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook Thomas Weißschuh
@ 2024-10-05 0:19 ` Song Liu
2024-10-05 13:45 ` Jiri Olsa
2024-10-08 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Song Liu @ 2024-10-05 0:19 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: KP Singh, Matt Bobrowski, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman,
Yonghong Song, John Fastabend, Stanislav Fomichev, Hao Luo,
Jiri Olsa, Casey Schaufler, Paul Moore, John Johansen, bpf,
linux-kernel
On Fri, Oct 4, 2024 at 5:07 PM Thomas Weißschuh <linux@weissschuh.net> wrote:
>
> The key_free LSM hook has been removed.
> Remove the corresponding BPF hook.
>
> Avoid warnings during the build:
> BTFIDS vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free
>
> Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
LGTM.
Acked-by: Song Liu <song@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook
2024-10-05 0:06 [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook Thomas Weißschuh
2024-10-05 0:19 ` Song Liu
@ 2024-10-05 13:45 ` Jiri Olsa
2024-10-08 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Olsa @ 2024-10-05 13:45 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: KP Singh, Matt Bobrowski, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
Yonghong Song, John Fastabend, Stanislav Fomichev, Hao Luo,
Casey Schaufler, Paul Moore, John Johansen, bpf, linux-kernel
On Sat, Oct 05, 2024 at 02:06:28AM +0200, Thomas Weißschuh wrote:
> The key_free LSM hook has been removed.
> Remove the corresponding BPF hook.
>
> Avoid warnings during the build:
> BTFIDS vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free
nice, I was wondering about that, lgtm
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> I don't know much about LSMs, so please disregard if this is wrong.
> ---
> kernel/bpf/bpf_lsm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c
> index 6292ac5f9bd139dafb39ecd8bb180be46cd7c7fd..3bc61628ab251e05d7837eb27dabc3b62bcc4783 100644
> --- a/kernel/bpf/bpf_lsm.c
> +++ b/kernel/bpf/bpf_lsm.c
> @@ -339,10 +339,6 @@ BTF_ID(func, bpf_lsm_path_chmod)
> BTF_ID(func, bpf_lsm_path_chown)
> #endif /* CONFIG_SECURITY_PATH */
>
> -#ifdef CONFIG_KEYS
> -BTF_ID(func, bpf_lsm_key_free)
> -#endif /* CONFIG_KEYS */
> -
> BTF_ID(func, bpf_lsm_mmap_file)
> BTF_ID(func, bpf_lsm_netlink_send)
> BTF_ID(func, bpf_lsm_path_notify)
>
> ---
> base-commit: 0c559323bbaabee7346c12e74b497e283aaafef5
> change-id: 20241005-lsm-key_free-b47445ee523d
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook
2024-10-05 0:06 [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook Thomas Weißschuh
2024-10-05 0:19 ` Song Liu
2024-10-05 13:45 ` Jiri Olsa
@ 2024-10-08 3:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-08 3:40 UTC (permalink / raw)
To: =?utf-8?q?Thomas_Wei=C3=9Fschuh_=3Clinux=40weissschuh=2Enet=3E?=
Cc: kpsingh, mattbobrowski, ast, daniel, andrii, martin.lau, eddyz87,
song, yonghong.song, john.fastabend, sdf, haoluo, jolsa, casey,
paul, john.johansen, bpf, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Sat, 05 Oct 2024 02:06:28 +0200 you wrote:
> The key_free LSM hook has been removed.
> Remove the corresponding BPF hook.
>
> Avoid warnings during the build:
> BTFIDS vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free
>
> [...]
Here is the summary with links:
- bpf, lsm: Remove bpf_lsm_key_free hook
https://git.kernel.org/bpf/bpf-next/c/31dd994c031a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-08 3:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-05 0:06 [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook Thomas Weißschuh
2024-10-05 0:19 ` Song Liu
2024-10-05 13:45 ` Jiri Olsa
2024-10-08 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox