BPF List
 help / color / mirror / Atom feed
From: Martin KaFai Lau <martin.lau@linux.dev>
To: thinker.li@gmail.com
Cc: sinquersw@gmail.com, kuifeng@meta.com, netdev@vger.kernel.org,
	bpf@vger.kernel.org, ast@kernel.org, song@kernel.org,
	kernel-team@meta.com, andrii@kernel.org, drosen@google.com
Subject: Re: [PATCH bpf-next v17 11/14] bpf, net: switch to dynamic registration
Date: Mon, 22 Jan 2024 23:11:51 -0800	[thread overview]
Message-ID: <a92ec3a9-10a2-40f5-83a4-81da51888d01@linux.dev> (raw)
In-Reply-To: <20240119225005.668602-12-thinker.li@gmail.com>

On 1/19/24 2:50 PM, thinker.li@gmail.com wrote:
> @@ -1792,6 +1799,12 @@ static inline int bpf_trampoline_link_cgroup_shim(struct bpf_prog *prog,
>   static inline void bpf_trampoline_unlink_cgroup_shim(struct bpf_prog *prog)
>   {
>   }
> +static inline int bpf_struct_ops_desc_init(struct bpf_struct_ops_desc *st_ops_desc,
> +					   struct btf *btf,
> +					   struct bpf_verifier_log *log) {
> +	return -EOPNOTSUPP;
> +}
> +

This part still does not look right. It is under the "#if 
defined(CONFIG_CGROUP_BPF)...".

No need to resend for now. I will try to adjust it unless I found other issues. 
Thanks.

  reply	other threads:[~2024-01-23  7:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 22:49 [PATCH bpf-next v17 00/14] Registrating struct_ops types from modules thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 01/14] bpf: refactory struct_ops type initialization to a function thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 02/14] bpf: get type information with BTF_ID_LIST thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 03/14] bpf, net: introduce bpf_struct_ops_desc thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 04/14] bpf: add struct_ops_tab to btf thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 05/14] bpf: make struct_ops_map support btfs other than btf_vmlinux thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 06/14] bpf: pass btf object id in bpf_map_info thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 07/14] bpf: lookup struct_ops types from a given module BTF thinker.li
2024-01-19 22:49 ` [PATCH bpf-next v17 08/14] bpf: pass attached BTF to the bpf_struct_ops subsystem thinker.li
2024-01-19 22:50 ` [PATCH bpf-next v17 09/14] bpf: hold module refcnt in bpf_struct_ops map creation and prog verification thinker.li
2024-01-19 22:50 ` [PATCH bpf-next v17 10/14] bpf: validate value_type thinker.li
2024-01-19 22:50 ` [PATCH bpf-next v17 11/14] bpf, net: switch to dynamic registration thinker.li
2024-01-23  7:11   ` Martin KaFai Lau [this message]
2024-01-19 22:50 ` [PATCH bpf-next v17 12/14] libbpf: Find correct module BTFs for struct_ops maps and progs thinker.li
2024-01-19 22:50 ` [PATCH bpf-next v17 13/14] bpf: export btf_ctx_access to modules thinker.li
2024-01-19 22:50 ` [PATCH bpf-next v17 14/14] selftests/bpf: test case for register_bpf_struct_ops() thinker.li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a92ec3a9-10a2-40f5-83a4-81da51888d01@linux.dev \
    --to=martin.lau@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=drosen@google.com \
    --cc=kernel-team@meta.com \
    --cc=kuifeng@meta.com \
    --cc=netdev@vger.kernel.org \
    --cc=sinquersw@gmail.com \
    --cc=song@kernel.org \
    --cc=thinker.li@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox