From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: Khawar Ahemad <ahemadkhawar123@gmail.com>, bpf@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
emil@etsalapatis.com, martin.lau@linux.dev,
yonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev,
Kumar Kartikeya Dwivedi <memxor@gmail.com>
Subject: Re: [PATCH bpf-next v6 4/4] selftests/bpf: Add a test for arena fault-in under memory.max
Date: Tue, 25 Aug 2026 19:19:58 +0800 [thread overview]
Message-ID: <ab878224-d75f-45e7-b625-39c4f56e548b@linux.dev> (raw)
In-Reply-To: <20260825104311.84038-1-ahemadkhawar123@gmail.com>
On 8/25/26 6:43 PM, Khawar Ahemad wrote:
> Addressing the three CI review comments on the v6 series:
>
> ---
> [Patch 4/4] max_entries comment
> ---
>
>> could the 50000 carry a short note that it just has to outrun
>> ARENA_BUDGET on the smallest page size
> Accepted. Will be fixed in v7 as a proper preceding block comment:
>
> /*
> * 50000 pages must exceed ARENA_BUDGET / PAGE_SIZE (64M / 4k = 16384)
> * so the fault loop hits memory.max before exhausting the arena itself.
> */
> __uint(max_entries, 50000);
Not that simple.
It also make sure the arean not exceed 4G when page size is 64K.
---
Please don't submit further versions of this patchset. I have already
prepared a
V6 (the one you sent), and I'm planning to send it myself. Additional
submissions
from you would create unnecessary conflicts and confusion.
If you're interested in this series, I'd really appreciate your review
and feedback instead.
I'll also be sure to cc you on future versions.
Best regards
next prev parent reply other threads:[~2026-08-25 11:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 9:49 [PATCH bpf-next v6 0/4] bpf: arena: handle memory.max on fault-in with reclaim/OOM Khawar Ahemad
2026-08-25 9:49 ` [PATCH bpf-next v6 1/4] bpf: Add a sleepable page allocator for map memory Khawar Ahemad
2026-08-25 10:11 ` sashiko-bot
2026-08-25 10:22 ` Khawar Ahemad
2026-08-25 10:32 ` bot+bpf-ci
2026-08-25 9:49 ` [PATCH bpf-next v6 2/4] bpf: arena: allocate the fault-in page outside the lock Khawar Ahemad
2026-08-25 10:32 ` bot+bpf-ci
2026-08-25 9:49 ` [PATCH bpf-next v6 3/4] selftests/bpf: Add read_cgroup_file() to cgroup_helpers Khawar Ahemad
2026-08-25 9:49 ` [PATCH bpf-next v6 4/4] selftests/bpf: Add a test for arena fault-in under memory.max Khawar Ahemad
2026-08-25 10:32 ` bot+bpf-ci
2026-08-25 10:43 ` Khawar Ahemad
2026-08-25 11:19 ` Jiayuan Chen [this message]
2026-08-25 12:23 ` Kumar Kartikeya Dwivedi
2026-08-25 11:28 ` Khawar Ahemad
2026-08-25 9:55 ` [PATCH bpf-next v6 0/4] bpf: arena: handle memory.max on fault-in with reclaim/OOM Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab878224-d75f-45e7-b625-39c4f56e548b@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=ahemadkhawar123@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox