BPF List
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: Jiri Olsa <olsajiri@gmail.com>,
	ast@kernel.org, andrii@kernel.org, eddyz87@gmail.com,
	daniel@iogearbox.net, ihor.solodrai@linux.dev,
	yonghong.song@linux.dev, song@kernel.org, qmo@kernel.org,
	martin.lau@linux.dev, memxor@gmail.com, emil@etsalapatis.com,
	bpf@vger.kernel.org, nsc@kernel.org, puranjay@kernel.org,
	yatsenko@meta.com
Subject: Re: [PATCH v3 bpf-next 09/11] bpftool: Add ability to dump LOC_PARAM, LOC_PROTO and LOCSEC
Date: Fri, 18 Sep 2026 15:01:45 +0200	[thread overview]
Message-ID: <aq02OQvU2GhTwHWD@krava> (raw)
In-Reply-To: <f5167878-54e5-4b89-8ffa-bc48a96fc651@oracle.com>

On Fri, Sep 18, 2026 at 10:19:33AM +0100, Alan Maguire wrote:
> On 17/09/2026 23:00, Jiri Olsa wrote:
> > On Thu, Sep 17, 2026 at 09:27:42AM +0100, Alan Maguire wrote:
> >> 
> >> 
> >> On 16/09/2026 23:07, Jiri Olsa wrote:
> >> > 
> >> > On Wed, Sep 16, 2026 at 08:41:16AM +0100, Alan Maguire wrote:
> >> >> In raw mode ensure we can dump new BTF kinds in normal/json format.
> >> >> BTF_KIND_LOC_PARAMs are rendered as strings, for example a
> >> >> const value of 0x2a and a dereference of r10 + 0x20:
> >> >> 
> >> >>   [12] LOC_PARAM '(anon)' size=4 flags=0x2 vlen=1 values='0x2a'
> >> >>   [13] LOC_PARAM '(anon)' size=8 flags=0x38 vlen=2 values='*(r10 + 0x20)'
> >> >> 
> >> >> LOC_PROTOs render the associated values of each of their
> >> >> LOC_PARAMs for easier readability:
> >> >> 
> >> >>   [14] LOC_PROTO '(anon)' vlen=2
> >> >>   	type_id=12 value='r1'
> >> >>   	type_id=13 value='*(r2 + 0x10)'
> >> > 
> >> > nit, AFAICT these are dwarf's registers numbers? could we output arch's register names?
> >> >
> >> 
> >> thanks for taking a look Jiri! You're right they are DWARF register numbers alright;
> >> the problem is to render them as arch register names we'd need to maintain per-arch
> >> tables in bpftool, which seems like the wrong place to host those. I'd suggest instead
> > 
> > is it that bad? I guess it's just simple fixed table
> > 
> > not sure how useful that output is with dwarf registers, you'll need to convert
> > it to arch regs anyway to make some sense of it.. we could save some tokens ;-)
> >
> 
> Well it is a raw dump; to draw the analogy with functions, we don't we print a C
> function prototype for a BTF_KIND_FUNC_PROTO; instead we print a set of BTF ids
> that comprise the parameters. The problem with converting it is it then becomes
> hard to relate the raw dump output back to what the BTF actually was, which is 
> often what you want to know when you're doing a raw dump. Now that pfunct supports
> split BTF I can roll support for printing per-site info including registers etc into
> it as part of the pahole changes respin.

ok, sounds good, thanks

jirka

  reply	other threads:[~2026-09-18 13:01 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  7:41 [PATCH v3 bpf-next 00/11] Support inline functions in BTF Alan Maguire
2026-09-16  7:41 ` [PATCH v3 bpf-next 01/11] btf: Extend UAPI to support BTF location (inline site) info Alan Maguire
2026-09-16  9:03   ` bot+bpf-ci
2026-09-16  7:41 ` [PATCH v3 bpf-next 02/11] libbpf: Add support for BTF kinds LOC[_PARAM|_PROTO|SEC] Alan Maguire
2026-09-16  7:55   ` sashiko-bot
2026-09-16  9:03   ` bot+bpf-ci
2026-09-16  7:41 ` [PATCH v3 bpf-next 03/11] selftests/bpf: Test helper support for BTF_KIND_LOC[_PARAM|_PROTO|SEC] Alan Maguire
2026-09-16  8:44   ` bot+bpf-ci
2026-09-18 18:34   ` Eduard Zingerman
2026-09-16  7:41 ` [PATCH v3 bpf-next 04/11] selftests/bpf: Add LOC_PARAM, LOC_PROTO, LOCSEC to field iter tests Alan Maguire
2026-09-18 18:43   ` Eduard Zingerman
2026-09-16  7:41 ` [PATCH v3 bpf-next 05/11] selftests/bpf: Add LOC_PARAM, LOC_PROTO, LOCSEC to dedup split tests Alan Maguire
2026-09-18 18:46   ` Eduard Zingerman
2026-09-16  7:41 ` [PATCH v3 bpf-next 06/11] selftests/bpf: BTF distill tests to ensure LOC[_PARAM|_PROTO] add to split BTF Alan Maguire
2026-09-18 19:59   ` Eduard Zingerman
2026-09-21 18:36     ` Alan Maguire
2026-09-16  7:41 ` [PATCH v3 bpf-next 07/11] bpftool: Handle multi-split BTF by supporting multiple base BTFs Alan Maguire
2026-09-16  7:54   ` sashiko-bot
2026-09-16  9:03   ` bot+bpf-ci
2026-09-16  7:41 ` [PATCH v3 bpf-next 08/11] bpftool: Document support for multi-split BTF Alan Maguire
2026-09-16  7:41 ` [PATCH v3 bpf-next 09/11] bpftool: Add ability to dump LOC_PARAM, LOC_PROTO and LOCSEC Alan Maguire
2026-09-16  7:55   ` sashiko-bot
2026-09-16  9:03   ` bot+bpf-ci
2026-09-16 22:07   ` Jiri Olsa
2026-09-17  8:27     ` Alan Maguire
2026-09-17 22:00       ` Jiri Olsa
2026-09-18  9:19         ` Alan Maguire
2026-09-18 13:01           ` Jiri Olsa [this message]
2026-09-17 16:06   ` Quentin Monnet
2026-09-17 17:32     ` Alan Maguire
2026-09-18  7:29     ` Alan Maguire
2026-09-18 20:51   ` Eduard Zingerman
2026-09-21 18:47     ` Alan Maguire
2026-09-21 21:46       ` Eduard Zingerman
2026-09-22 11:59         ` Quentin Monnet
2026-09-23  8:47           ` Alan Maguire
2026-09-16  7:41 ` [PATCH v3 bpf-next 10/11] selftests/bpf: Test bpftool dump of BTF location info Alan Maguire
2026-09-16  7:56   ` sashiko-bot
2026-09-16  9:03   ` bot+bpf-ci
2026-09-16  7:41 ` [PATCH v3 bpf-next 11/11] Documentation/bpf: Describe new location-related BTF kinds Alan Maguire
2026-09-16  8:01   ` sashiko-bot
2026-09-16  9:03   ` bot+bpf-ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq02OQvU2GhTwHWD@krava \
    --to=olsajiri@gmail.com \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=nsc@kernel.org \
    --cc=puranjay@kernel.org \
    --cc=qmo@kernel.org \
    --cc=song@kernel.org \
    --cc=yatsenko@meta.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox