From: Geliang Tang <geliang@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v9 00/11] use network helpers, part 8
Date: Mon, 08 Jul 2024 10:36:19 +0800 [thread overview]
Message-ID: <b1f481c52bd11ba3d45613f5ee411429dd608ede.camel@kernel.org> (raw)
In-Reply-To: <cover.1720276189.git.tanggeliang@kylinos.cn>
On Sat, 2024-07-06 at 22:45 +0800, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v9:
> - new patches 5-7, new struct member expect_errno for
> network_helper_opts.
> - patches 1-4, 8-9 unchanged.
> - update patches 10-11 to make sure all tests pass.
Superseded, v10 is sent.
Thanks,
-Geliang
>
> v8:
> - only patch 8 updated, to fix errors reported by CI.
>
> v7:
> - address Martin's comments in v6. (thanks)
> - use MAX(opts->backlog, 0) instead of opts->backlog.
> - use connect_to_fd_opts instead connect_to_fd.
> - more ASSERT_* to check errors.
>
> v6:
> - update patch 6 as Daniel suggested. (thanks)
>
> v5:
> - keep make_server and make_client as Eduard suggested.
>
> v4:
> - a new patch to use make_sockaddr in sockmap_ktls.
> - a new patch to close fd in error path in drop_on_reuseport.
> - drop make_server() in patch 7.
> - drop make_client() too in patch 9.
>
> v3:
> - a new patch to add backlog for network_helper_opts.
> - use start_server_str in sockmap_ktls now, not start_server.
>
> v2:
> - address Eduard's comments in v1. (thanks)
> - fix errors reported by CI.
>
> This patch set uses network helpers in sockmap_ktls and sk_lookup,
> and
> drop three local helpers tcp_server(), inetaddr_len() and
> make_socket()
> in them.
>
> Geliang Tang (11):
> selftests/bpf: Add backlog for network_helper_opts
> selftests/bpf: Use start_server_str in sockmap_ktls
> selftests/bpf: Use connect_to_fd_opts in sockmap_ktls
> selftests/bpf: Use make_sockaddr in sockmap_ktls
> selftests/bpf: Add network_helper_opts for connect_fd_to_fd
> selftests/bpf: Add expect_errno for network_helper_opts
> selftests/bpf: Set expect_errno for cgroup_skb_sk_lookup
> selftests/bpf: Close fd in error path in drop_on_reuseport
> selftests/bpf: Use start_server_str in sk_lookup
> selftests/bpf: Use connect_to_addr in sk_lookup
> selftests/bpf: Drop make_socket in sk_lookup
>
> tools/testing/selftests/bpf/network_helpers.c | 23 ++-
> tools/testing/selftests/bpf/network_helpers.h | 8 +-
> .../testing/selftests/bpf/prog_tests/bpf_nf.c | 5 +-
> .../bpf/prog_tests/cgroup_skb_sk_lookup.c | 8 +-
> .../selftests/bpf/prog_tests/cgroup_tcp_skb.c | 4 +-
> .../selftests/bpf/prog_tests/cgroup_v1v2.c | 1 +
> .../selftests/bpf/prog_tests/sk_lookup.c | 152 +++++++---------
> --
> .../selftests/bpf/prog_tests/sockmap_ktls.c | 53 ++----
> 8 files changed, 106 insertions(+), 148 deletions(-)
>
prev parent reply other threads:[~2024-07-08 2:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 14:45 [PATCH bpf-next v9 00/11] use network helpers, part 8 Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 01/11] selftests/bpf: Add backlog for network_helper_opts Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 02/11] selftests/bpf: Use start_server_str in sockmap_ktls Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 03/11] selftests/bpf: Use connect_to_fd_opts " Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 04/11] selftests/bpf: Use make_sockaddr " Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 05/11] selftests/bpf: Add network_helper_opts for connect_fd_to_fd Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 06/11] selftests/bpf: Add expect_errno for network_helper_opts Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 07/11] selftests/bpf: Set expect_errno for cgroup_skb_sk_lookup Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 08/11] selftests/bpf: Close fd in error path in drop_on_reuseport Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 09/11] selftests/bpf: Use start_server_str in sk_lookup Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 10/11] selftests/bpf: Use connect_to_addr " Geliang Tang
2024-07-06 14:45 ` [PATCH bpf-next v9 11/11] selftests/bpf: Drop make_socket " Geliang Tang
2024-07-08 2:36 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1f481c52bd11ba3d45613f5ee411429dd608ede.camel@kernel.org \
--to=geliang@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox