From: Eduard Zingerman <eddyz87@gmail.com>
To: Emil Tsalapatis <emil@etsalapatis.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, andrii@kernel.org, memxor@gmail.com,
daniel@iogearbox.net, song@kernel.org, mattbobrowski@google.com
Subject: Re: [PATCH bpf-next v2 4/5] selftests/bpf: Remove __arg_arena from the codebase
Date: Mon, 01 Jun 2026 12:06:11 -0700 [thread overview]
Message-ID: <c2115949da23680fa7f424cfcf86e1b96e117071.camel@gmail.com> (raw)
In-Reply-To: <20260530002259.4505-5-emil@etsalapatis.com>
On Fri, 2026-05-29 at 20:22 -0400, Emil Tsalapatis wrote:
> Now that BPF __arg_arena has been subsumed by __arena, remove
> __arg_arena from the codebase. This way the user has one fewer
> annotation to worry about.
>
> To remove __arg_arena we remove the typedefs we were previously
> using to minimize __arena annotations. This is because __arena
> now also includes a BTF type tag, which is ignored for non-pointer
> types. As a result, we cannot capture the whole __arena annotation
> inside a typedef and need to directly annotate the pointer type when
> declaring the variable.
>
> The extra verbosity is worth it because the use of the __arena tag
> is intuitive to the programmer and removes the __arg_arena tag that
> has been a consistent source of confusion for users. The typedefs
> can be reintroduced later (without __arg_arena) once compilers start
> supporting BTF type tags for non-pointer types.
>
> Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
> ---
Do we want to add a dedicated test in verifier_arena_globals1.c?
[...]
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2026-06-01 19:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 0:22 [PATCH bpf-next v2 0/5] bpf: Minimize annotations for arena programs Emil Tsalapatis
2026-05-30 0:22 ` [PATCH bpf-next v2 1/5] selftests/bpf: libarena: Add "arena" BTF type tag to __arena qualifier Emil Tsalapatis
2026-05-30 0:22 ` [PATCH bpf-next v2 2/5] verifier: parse BTF type tags for function arguments Emil Tsalapatis
2026-05-30 0:59 ` sashiko-bot
2026-06-01 5:12 ` Emil Tsalapatis
2026-06-01 18:37 ` Eduard Zingerman
2026-06-01 19:13 ` Emil Tsalapatis
2026-06-01 19:14 ` Eduard Zingerman
2026-05-30 0:22 ` [PATCH bpf-next v2 3/5] bpf: Allow subprogs to return arena pointers Emil Tsalapatis
2026-05-30 4:54 ` sashiko-bot
2026-06-01 5:09 ` Emil Tsalapatis
2026-06-01 19:01 ` Eduard Zingerman
2026-06-02 0:06 ` Emil Tsalapatis
2026-05-30 0:22 ` [PATCH bpf-next v2 4/5] selftests/bpf: Remove __arg_arena from the codebase Emil Tsalapatis
2026-05-30 5:03 ` sashiko-bot
2026-05-31 5:18 ` Alexei Starovoitov
2026-06-01 5:03 ` Emil Tsalapatis
2026-06-01 19:06 ` Eduard Zingerman [this message]
2026-05-30 0:22 ` [PATCH bpf-next v2 5/5] selftests/bpf: libarena: Directly return arena pointers from functions Emil Tsalapatis
2026-06-01 19:07 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2115949da23680fa7f424cfcf86e1b96e117071.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=mattbobrowski@google.com \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox