From: Eduard Zingerman <eddyz87@gmail.com>
To: Emil Tsalapatis <emil@etsalapatis.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, andrii@kernel.org, memxor@gmail.com,
daniel@iogearbox.net, song@kernel.org, mattbobrowski@google.com
Subject: Re: [PATCH bpf-next v2 2/5] verifier: parse BTF type tags for function arguments
Date: Mon, 01 Jun 2026 11:37:47 -0700 [thread overview]
Message-ID: <e1a40461fa792dc7687b0029f3ede546eeeacbc9.camel@gmail.com> (raw)
In-Reply-To: <20260530002259.4505-3-emil@etsalapatis.com>
On Fri, 2026-05-29 at 20:22 -0400, Emil Tsalapatis wrote:
> The BTF parsing logic for function arguments goes through
> the arguments' decl tags, but does not go into their type
> tags. Add type tag parsing for function arguments.
>
> Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
> +static int btf_scan_type_tags(struct bpf_verifier_env *env,
> + const struct btf *btf, u32 type_id,
> + u32 *tags)
> +{
> + const struct btf_type *t;
> +
> + /* Find the first pointer type in the chain. */
> + t = btf_type_skip_modifiers(btf, type_id, NULL);
> + if (!t || !btf_type_is_ptr(t))
> + return 0;
Nit: do we want to report -EOPNOTSUPP if type tag is attached to a non-pointer type?
> +
> + /* We got a pointer, get all associated type tags. */
> + t = btf_type_by_id(btf, t->type);
> + while (t && btf_type_is_type_tag(t)) {
> + const char *tag = __btf_name_by_offset(btf, t->name_off);
> +
> + if (strcmp(tag, "arena") == 0) {
> + *tags |= ARG_TAG_ARENA;
> + } else {
> + bpf_log(&env->log, "function signature member has unsupported type tag '%s'\n",
> + tag);
> + return -EOPNOTSUPP;
> + }
> +
> + t = btf_type_by_id(btf, t->type);
> + }
> +
> + return 0;
> +}
> +
[...]
next prev parent reply other threads:[~2026-06-01 18:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 0:22 [PATCH bpf-next v2 0/5] bpf: Minimize annotations for arena programs Emil Tsalapatis
2026-05-30 0:22 ` [PATCH bpf-next v2 1/5] selftests/bpf: libarena: Add "arena" BTF type tag to __arena qualifier Emil Tsalapatis
2026-05-30 0:22 ` [PATCH bpf-next v2 2/5] verifier: parse BTF type tags for function arguments Emil Tsalapatis
2026-05-30 0:59 ` sashiko-bot
2026-06-01 5:12 ` Emil Tsalapatis
2026-06-01 18:37 ` Eduard Zingerman [this message]
2026-06-01 19:13 ` Emil Tsalapatis
2026-06-01 19:14 ` Eduard Zingerman
2026-05-30 0:22 ` [PATCH bpf-next v2 3/5] bpf: Allow subprogs to return arena pointers Emil Tsalapatis
2026-05-30 4:54 ` sashiko-bot
2026-06-01 5:09 ` Emil Tsalapatis
2026-06-01 19:01 ` Eduard Zingerman
2026-06-02 0:06 ` Emil Tsalapatis
2026-05-30 0:22 ` [PATCH bpf-next v2 4/5] selftests/bpf: Remove __arg_arena from the codebase Emil Tsalapatis
2026-05-30 5:03 ` sashiko-bot
2026-05-31 5:18 ` Alexei Starovoitov
2026-06-01 5:03 ` Emil Tsalapatis
2026-06-01 19:06 ` Eduard Zingerman
2026-05-30 0:22 ` [PATCH bpf-next v2 5/5] selftests/bpf: libarena: Directly return arena pointers from functions Emil Tsalapatis
2026-06-01 19:07 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a40461fa792dc7687b0029f3ede546eeeacbc9.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=mattbobrowski@google.com \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox