From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
bpf@vger.kernel.org, Joel Fernandes <joel@joelfernandes.org>,
Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH v5 3/8] cleanup.h: Introduce DEFINE_INACTIVE_GUARD and activate_guard
Date: Wed, 28 Aug 2024 09:58:25 -0400 [thread overview]
Message-ID: <c262fb90-2a3f-49a2-b89d-467f493088cb@efficios.com> (raw)
In-Reply-To: <20240819190014.31ab74d8@gandalf.local.home>
On 2024-08-20 01:00, Steven Rostedt wrote:
> On Thu, 27 Jun 2024 11:23:35 -0400
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
>> To cover scenarios where the scope of the guard differs from the scope
>> of its activation, introduce DEFINE_INACTIVE_GUARD() and activate_guard().
>>
>> Here is an example use for a conditionally activated guard variable:
>>
>> void func(bool a)
>> {
>> DEFINE_INACTIVE_GUARD(preempt_notrace, myguard);
>>
>> [...]
>> if (a) {
>> might_sleep();
>> activate_guard(preempt_notrace, myguard)();
>> }
>> [ protected code ]
>> }
>>
>
> Hi Mathieu,
>
> The three cleanup patches fail to apply (I believe one has already been
> fixed by Ingo too). Could you have the clean up patches be a separate
> series that is likely to get in, especially since it's more of a moving
> target.
Then it would make sense to split this into two series: one for the
guard stuff, and one for tracing which depends on the first one.
I'll do that.
Mathieu
>
> Thanks,
>
> -- Steve
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2024-08-28 13:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 15:23 [PATCH v5 0/8] Faultable Tracepoints Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 1/8] cleanup.h: Header include guard should match header name Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 2/8] cleanup.h guard: Rename DEFINE_ prefix to DECLARE_ Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 3/8] cleanup.h: Introduce DEFINE_INACTIVE_GUARD and activate_guard Mathieu Desnoyers
2024-08-19 23:00 ` Steven Rostedt
2024-08-28 13:58 ` Mathieu Desnoyers [this message]
2024-06-27 15:23 ` [PATCH v5 4/8] tracing: Introduce faultable tracepoints Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 5/8] tracing/ftrace: Add support for " Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 6/8] tracing/bpf-trace: " Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 7/8] tracing/perf: " Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 8/8] tracing: Convert sys_enter/exit to " Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2024-06-26 18:59 [PATCH v5 0/8] Faultable Tracepoints Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 3/8] cleanup.h: Introduce DEFINE_INACTIVE_GUARD and activate_guard Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c262fb90-2a3f-49a2-b89d-467f493088cb@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=jolsa@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=torvalds@linux-foundation.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox