From: Daniel Borkmann <daniel@iogearbox.net>
To: Jordan Rife <jordan@jrife.io>, Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
stephen@networkplumber.org, dsahern@kernel.org
Subject: Re: [PATCH iproute2-next v2] ip: link: netkit: Support scrub options
Date: Mon, 24 Feb 2025 17:56:03 +0100 [thread overview]
Message-ID: <c648552e-e9e9-4104-ab34-2926efa949f2@iogearbox.net> (raw)
In-Reply-To: <20250224164903.138865-1-jordan@jrife.io>
On 2/24/25 5:49 PM, Jordan Rife wrote:
> Add "scrub" option to configure IFLA_NETKIT_SCRUB and
> IFLA_NETKIT_PEER_SCRUB when setting up a link. Add "scrub" and
> "peer scrub" to device details as well when printing.
>
> $ sudo ./ip/ip link add jordan type netkit scrub default peer scrub none
> $ ./ip/ip -details link show jordan
> 43: jordan@nk0: <BROADCAST,MULTICAST,NOARP,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 allmulti 0 minmtu 68 maxmtu 65535
> netkit mode l3 type primary policy forward peer policy forward scrub default peer scrub none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 tso_max_size 524280 tso_max_segs 65535 gro_max_size 65536 gso_ipv4_max_size 65536 gro_ipv4_max_size 65536
>
> v1->v2: Added some spaces around "scrub SCRUB" in the help message.
>
> Link: https://lore.kernel.org/netdev/20241004101335.117711-1-daniel@iogearbox.net/
>
> Signed-off-by: Jordan Rife <jordan@jrife.io>
lgtm, thanks!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2025-02-24 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 16:49 [PATCH iproute2-next v2] ip: link: netkit: Support scrub options Jordan Rife
2025-02-24 16:56 ` Daniel Borkmann [this message]
2025-02-24 17:00 ` Nikolay Aleksandrov
2025-02-26 15:56 ` David Ahern
2025-02-26 17:04 ` Jordan Rife
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c648552e-e9e9-4104-ab34-2926efa949f2@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=dsahern@kernel.org \
--cc=jordan@jrife.io \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox