From: David Ahern <dsahern@kernel.org>
To: Jordan Rife <jordan@jrife.io>,
Daniel Borkmann <daniel@iogearbox.net>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next v2] ip: link: netkit: Support scrub options
Date: Wed, 26 Feb 2025 08:56:59 -0700 [thread overview]
Message-ID: <f1854274-653a-414a-9300-c2e805d2ce14@kernel.org> (raw)
In-Reply-To: <20250224164903.138865-1-jordan@jrife.io>
On 2/24/25 9:49 AM, Jordan Rife wrote:
> diff --git a/ip/iplink_netkit.c b/ip/iplink_netkit.c
> index 49550a2e..818da119 100644
> --- a/ip/iplink_netkit.c
> +++ b/ip/iplink_netkit.c
> @@ -24,13 +24,19 @@ static const char * const netkit_policy_strings[] = {
> [NETKIT_DROP] = "blackhole",
> };
>
> +static const char * const netkit_scrub_strings[] = {
> + [NETKIT_SCRUB_NONE] = "none",
> + [NETKIT_SCRUB_DEFAULT] = "default",
> +};
> +
> static void explain(struct link_util *lu, FILE *f)
> {
> fprintf(f,
> - "Usage: ... %s [ mode MODE ] [ POLICY ] [ peer [ POLICY <options> ] ]\n"
> + "Usage: ... %s [ mode MODE ] [ POLICY ] [ scrub SCRUB ] [ peer [ POLICY <options> ] ]\n"
> "\n"
> "MODE: l3 | l2\n"
> "POLICY: forward | blackhole\n"
> + "SCRUB: default | none\n"
needs an update to the man page.
next prev parent reply other threads:[~2025-02-26 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 16:49 [PATCH iproute2-next v2] ip: link: netkit: Support scrub options Jordan Rife
2025-02-24 16:56 ` Daniel Borkmann
2025-02-24 17:00 ` Nikolay Aleksandrov
2025-02-26 15:56 ` David Ahern [this message]
2025-02-26 17:04 ` Jordan Rife
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1854274-653a-414a-9300-c2e805d2ce14@kernel.org \
--to=dsahern@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jordan@jrife.io \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox