From: Eduard Zingerman <eddyz87@gmail.com>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com,
yonghong.song@linux.dev, masahiroy@kernel.org
Subject: Re: [PATCH bpf v2] samples/bpf: remove unnecessary -I flags from libbpf EXTRA_CFLAGS
Date: Mon, 02 Dec 2024 17:44:30 -0800 [thread overview]
Message-ID: <d451820d25395d013e716884bb037af2aff50115.camel@gmail.com> (raw)
In-Reply-To: <ed5cd40f87b28528cd6a9a6db55e9879e34d9e92.camel@gmail.com>
On Mon, 2024-12-02 at 16:52 -0800, Eduard Zingerman wrote:
[...]
> > Naive question: why pass EXTRA_CFLAGS to libbpf at all? Can we drop it?
>
> This was added by the commit [0].
> As far as I understand, the idea is to pass the following flags:
>
> ifeq ($(ARCH), arm)
> # Strip all except -D__LINUX_ARM_ARCH__ option needed to handle linux
> # headers when arm instruction set identification is requested.
> ARM_ARCH_SELECTOR := $(filter -D__LINUX_ARM_ARCH__%, $(KBUILD_CFLAGS))
> ...
> TPROGS_CFLAGS += $(ARM_ARCH_SELECTOR)
> endif
>
> ifeq ($(ARCH), mips)
> TPROGS_CFLAGS += -D__SANE_USERSPACE_TYPES__
> ...
> endif
>
> Not sure if these are still necessary.
>
> [0] commit d8ceae91e9f0 ("samples/bpf: Provide C/LDFLAGS to libbpf")
>
But this means that I should include sysroot part in the COMMON_CFLAGS.
I'll get the arm cross-compilation environment and double check.
next prev parent reply other threads:[~2024-12-03 1:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 23:47 [PATCH bpf v2] samples/bpf: remove unnecessary -I flags from libbpf EXTRA_CFLAGS Eduard Zingerman
2024-12-03 0:23 ` Stanislav Fomichev
2024-12-03 0:52 ` Eduard Zingerman
2024-12-03 1:44 ` Eduard Zingerman [this message]
2024-12-03 4:50 ` Eduard Zingerman
2024-12-03 5:00 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d451820d25395d013e716884bb037af2aff50115.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=masahiroy@kernel.org \
--cc=stfomichev@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox