From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrei Matei <andreimatei1@gmail.com>,
bpf@vger.kernel.org, andrii.nakryiko@gmail.com,
sunhao.th@gmail.com
Subject: Re: [PATCH bpf v3 0/2] bpf: fix verification of indirect var-off stack access
Date: Wed, 06 Dec 2023 01:35:44 +0200 [thread overview]
Message-ID: <e3787b1d4c2d7a6b02ca6561edad92fbc27cb6ba.camel@gmail.com> (raw)
In-Reply-To: <20231205193250.260862-1-andreimatei1@gmail.com>
On Tue, 2023-12-05 at 14:32 -0500, Andrei Matei wrote:
> V2 to V3:
> - simplify checks for max_off (don't call
> check_stack_slot_within_bounds for it)
> - append a commit to protect against overflow in the addition of the
> register and the offset
>
> V1 to V2:
> - fix max_off calculation for access size = 0
>
> Andrei Matei (2):
> bpf: fix verification of indirect var-off stack access
> bpf: guard stack limits against 32bit overflow
>
> kernel/bpf/verifier.c | 20 +++++++-------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
>
I think we also need a selftest, at-least for patch #1.
next prev parent reply other threads:[~2023-12-05 23:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 19:32 [PATCH bpf v3 0/2] bpf: fix verification of indirect var-off stack access Andrei Matei
2023-12-05 19:32 ` [PATCH bpf v3 1/2] " Andrei Matei
2023-12-06 0:27 ` Eduard Zingerman
2023-12-05 19:32 ` [PATCH bpf v3 2/2] bpf: guard stack limits against 32bit overflow Andrei Matei
2023-12-05 23:35 ` Eduard Zingerman [this message]
2023-12-06 0:08 ` [PATCH bpf v3 0/2] bpf: fix verification of indirect var-off stack access Alexei Starovoitov
2023-12-06 16:57 ` Andrei Matei
2023-12-06 17:14 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3787b1d4c2d7a6b02ca6561edad92fbc27cb6ba.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andreimatei1@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=sunhao.th@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox