From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"song@kernel.org" <song@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Cc: "daniel@iogearbox.net" <daniel@iogearbox.net>,
"Torvalds, Linus" <torvalds@linux-foundation.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"ast@kernel.org" <ast@kernel.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>
Subject: Re: [PATCH bpf-next 2/5] x86/alternative: introduce text_poke_set
Date: Tue, 17 May 2022 19:16:41 +0000 [thread overview]
Message-ID: <e681c4083fc53cedded845301e8df7a4910d1075.camel@intel.com> (raw)
In-Reply-To: <20220516054051.114490-3-song@kernel.org>
On Sun, 2022-05-15 at 22:40 -0700, Song Liu wrote:
> +static void text_poke_memset(void *dst, const void *src, size_t len)
> +{
> + int c = *(int *)src;
It casts away the const unnecessarily. It could be *(const int *)src.
> +
> + memset(dst, c, len);
> +}
> +
next prev parent reply other threads:[~2022-05-17 19:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 5:40 [PATCH bpf-next 0/5] bpf_prog_pack followup Song Liu
2022-05-16 5:40 ` [PATCH bpf-next 1/5] bpf: fill new bpf_prog_pack with illegal instructions Song Liu
2022-05-16 5:40 ` [PATCH bpf-next 2/5] x86/alternative: introduce text_poke_set Song Liu
2022-05-17 19:16 ` Edgecombe, Rick P [this message]
2022-05-17 21:09 ` Song Liu
2022-05-18 6:58 ` Song Liu
2022-05-18 7:45 ` Peter Zijlstra
2022-05-18 15:32 ` Song Liu
2022-05-18 17:09 ` Peter Zijlstra
2022-05-18 18:34 ` Song Liu
2022-05-19 7:38 ` Peter Zijlstra
2022-05-16 5:40 ` [PATCH bpf-next 3/5] bpf: introduce bpf_arch_text_invalidate for bpf_prog_pack Song Liu
2022-05-16 5:40 ` [PATCH bpf-next 4/5] module: introduce module_alloc_huge Song Liu
2022-05-18 6:28 ` Song Liu
2022-05-16 5:40 ` [PATCH bpf-next 5/5] bpf: use module_alloc_huge for bpf_prog_pack Song Liu
2022-05-17 19:15 ` Edgecombe, Rick P
2022-05-17 21:08 ` Song Liu
2022-05-17 23:58 ` Edgecombe, Rick P
2022-05-18 6:25 ` Song Liu
2022-05-18 6:34 ` Song Liu
2022-05-18 16:49 ` Edgecombe, Rick P
2022-05-18 18:31 ` Song Liu
2022-05-19 6:42 ` Song Liu
2022-05-19 16:56 ` Edgecombe, Rick P
2022-05-19 18:25 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e681c4083fc53cedded845301e8df7a4910d1075.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox