Re: [PATCH bpf-next v10 17/24] libbpf: Add cleanup_info to bpf_prog_load_opts

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: multi-line comment style violation in bpf.h
--

commit 2303147a5a35e813efcbbbd93de02e9883d03746
Author: Yonghong Song <yonghong.song@linux.dev>

libbpf: Add cleanup_info to bpf_prog_load_opts

This commit extends struct bpf_prog_load_opts by adding cleanup_info,
cleanup_info_cnt, and cleanup_info_rec_size fields. This allows a caller to
pass an exception cleanup table to the kernel via bpf_prog_load.

> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index 826d9cc9ab65d..64699e0e4e1a8 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -128,9 +128,17 @@ struct bpf_prog_load_opts {
>  
>  	/* if set, provides the length of fd_array */
>  	__u32 fd_array_cnt;
> +
> +	/* exception cleanup table: cleanup_info_cnt records of
> +	 * cleanup_info_rec_size bytes each (struct bpf_cleanup_info),
> +	 * holding instruction indices into insns
> +	 */

[Severity: Low]
This isn't a functional bug, but does this multi-line comment in struct
bpf_prog_load_opts follow the preferred BPF subsystem style? 

The BPF subsystem style guide mandates that all multi-line comments
should have the opening /* on its own line, with the comment text
starting on the subsequent line.

> +	__u32 cleanup_info_cnt;
> +	const void *cleanup_info;
> +	__u32 cleanup_info_rec_size;
>  	size_t :0;
>  };
> -#define bpf_prog_load_opts__last_field fd_array_cnt
> +#define bpf_prog_load_opts__last_field cleanup_info_rec_size

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009041447.17092-1-yonghong.song@linux.dev?part=17