Re: [PATCH v4 net-next 03/15] selftests: xsk: drop the single-interface loopback mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: Multi-line comments do not start with /* on its own line
--

commit f56c850eb3f84acec00c6d23c81d2796961df979
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

selftests: xsk: drop the single-interface loopback mode

This commit drops the single-interface loopback mode from xsk selftests,
removes the shared-UMEM TX setup and resizing code, and sets up hardware-based
traffic testing using ntuple and RSS configuration instead.

> diff --git a/tools/testing/selftests/bpf/prog_tests/test_xsk.c b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> index 05457f77ca52c..b9126fe66e1a7 100644
> --- a/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> +++ b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
[ ... ]
> @@ -2481,14 +2379,19 @@ int testapp_xdp_metadata_mb(struct test_spec *test)
>  	return testapp_xdp_metadata_copy(test);
>  }
>  
> +/* Expects the HW TX ring of the sender to hold DEFAULT_BATCH_SIZE
> + * descriptors.
> + */

[Severity: Low]
This isn't a bug, but does the comment for testapp_hw_sw_min_ring_size
in tools/testing/selftests/bpf/prog_tests/test_xsk.c violate the BPF
subsystem multi-line comment style? The BPF guidelines specify that
multi-line comments should start with an empty /* line instead of putting
text on the opening line.

>  int testapp_hw_sw_min_ring_size(struct test_spec *test)
>  {
>  	int ret;
[ ... ]
> @@ -2501,16 +2404,21 @@ int testapp_hw_sw_min_ring_size(struct test_spec *test)
>  	return testapp_validate_traffic(test);
>  }
>  
> +/* Expects the HW TX ring of the sender and the HW RX ring of the receiver
> + * at their maximum sizes.
> + */

[Severity: Low]
This isn't a bug, but does the comment for testapp_hw_sw_max_ring_size
in tools/testing/selftests/bpf/prog_tests/test_xsk.c violate the BPF
subsystem multi-line comment style? Similar to the previous finding, BPF
multi-line comments should start with the opening /* on its own line.

>  int testapp_hw_sw_max_ring_size(struct test_spec *test)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016174338.787135-1-maciej.fijalkowski@intel.com?part=3