Re: [PATCH v4 net-next 09/15] selftests: xsk: run one test case per xskxceiver invocation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] selftests: missing prerequisites (root, veth) cause hard failure instead of skip
--

commit 621c952e0f68b97c93b16b3262842ed60506e7fc
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

selftests: xsk: run one test case per xskxceiver invocation

Replace test_xsk.sh and xsk_prereqs.sh with test_xsk.py to run xskxceiver once
per mode and case. The new Python script relies on the networking selftests
Python library to manage test cases and resources.

> diff --git a/tools/testing/selftests/net/test_xsk.py b/tools/testing/selftests/net/test_xsk.py
> new file mode 100755
> index 0000000000000..80ac67cdebb66
> --- /dev/null
> +++ b/tools/testing/selftests/net/test_xsk.py
[ ... ]
> +def _veth_pair(busy_poll):
> +    pfx = f"xsk{random.randrange(1 << 20):05x}"
> +    veths = (pfx + "a", pfx + "b")
> +    ip(f"link add {veths[0]} numtxqueues 4 numrxqueues 4 type veth "
> +       f"peer name {veths[1]} numtxqueues 4 numrxqueues 4")

[Severity: Medium]
When the test suite is run as a non-root user or on a system without veth
module support, will this cause a hard failure rather than a skip?

The previous xsk_prereqs.sh script explicitly checked for root privileges and
veth support, returning ksft_skip gracefully if they were missing. Here, the
ip() command will raise a CmdExitFailure exception if the privileges or driver
are missing, which the test runner catches and reports as a failure.

Could this turn an environment difference into a false regression signal?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016174338.787135-1-maciej.fijalkowski@intel.com?part=9